Skip to content

Introduce a placeholder declaration to represent editor placeholders in member decl lists #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2023

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jan 4, 2023

As suggested in swiftlang/swift-format#462

Copy link
Member

@allevato allevato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

I do like this better than the idea to use unexpected nodes, since it separates a case that's valid for formatting over one that's difficult to distinguish from other unexpected nodes.

@ahoppen
Copy link
Member Author

ahoppen commented Jan 4, 2023

Yes, I changed my mind after I posted the comment on the issue in swift-format 😉 This turned out to be simpler

@ahoppen ahoppen force-pushed the ahoppen/placeholder-decl branch from 9662db2 to 454c729 Compare January 10, 2023 19:44
@ahoppen
Copy link
Member Author

ahoppen commented Jan 10, 2023

@swift-ci Please test

@ahoppen ahoppen force-pushed the ahoppen/placeholder-decl branch from 454c729 to 7fd8a8f Compare January 12, 2023 10:31
@ahoppen
Copy link
Member Author

ahoppen commented Jan 12, 2023

@swift-ci Please test

@ahoppen ahoppen force-pushed the ahoppen/placeholder-decl branch from 7fd8a8f to 6d5fc5b Compare January 13, 2023 17:46
@ahoppen
Copy link
Member Author

ahoppen commented Jan 13, 2023

@swift-ci Please test

@ahoppen ahoppen force-pushed the ahoppen/placeholder-decl branch from 6d5fc5b to 339e374 Compare January 13, 2023 20:19
@ahoppen
Copy link
Member Author

ahoppen commented Jan 13, 2023

@swift-ci Please test

@ahoppen ahoppen force-pushed the ahoppen/placeholder-decl branch from 339e374 to b666801 Compare January 14, 2023 07:17
@ahoppen
Copy link
Member Author

ahoppen commented Jan 14, 2023

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Jan 14, 2023

@swift-ci Please test macOS

@ahoppen ahoppen merged commit 30e2888 into swiftlang:main Jan 14, 2023
@ahoppen ahoppen deleted the ahoppen/placeholder-decl branch January 14, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants