Remove TokenSyntax shorthand static members for SwiftSyntaxBuilder
#1231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In an effort to unify SwiftSyntax and SwiftSyntaxBuilder I think we should remove the shorthand static members to create tokens in SwiftSyntaxBuilder that drop the `Token` suffix. In a follow-up PR I will investigate whether it makes sense to drop the `Token` suffix from the token static members in SwiftSyntax. rdar://104090850
kimdv
approved these changes
Jan 14, 2023
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to unify SwiftSyntax and SwiftSyntaxBuilder I think we should remove the shorthand static members to create tokens in SwiftSyntaxBuilder that drop the
Tokensuffix.In a follow-up PR I will investigate whether it makes sense to drop the
Tokensuffix from the token static members in SwiftSyntax.rdar://104090850