Skip to content

[CMake] Fix detecting -disable-implicit-string-processing-module-import #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Mar 16, 2023

The check command used to always fail because it fails to load stdlib. Workaround it by adding '-parse-stdlib' to the check command.

The check command used to always fail because it fails to load stdlib.
Workaround it by adding '-parse-stdlib' to the check command.
@rintaro rintaro requested a review from ahoppen as a code owner March 16, 2023 23:37
@rintaro
Copy link
Member Author

rintaro commented Mar 16, 2023

@swift-ci Please test

@rintaro rintaro requested a review from DougGregor March 16, 2023 23:37
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you if you say that this fixes things.

@rintaro rintaro merged commit 07c08da into swiftlang:main Mar 17, 2023
@rintaro rintaro deleted the cmake-swiftimplictimport branch March 20, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants