Skip to content

[5.9] Add missing trait conformances #1788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jun 15, 2023

  • Explanation: TypealiasDeclSyntax is missing conformance to WithAttributesSyntax. We should add it. Same for a couple more types that should conform to WithTrailingComma.
  • Risk: Low, these conformances should have always existed
  • Testing: Ran unit tests
  • Issue: rdar://110818997
  • Reviewer: @bnbarham on Add missing trait conformances #1784

These trait conformances were simply missing. Add them.

rdar://110818997
@ahoppen ahoppen requested a review from DougGregor as a code owner June 15, 2023 05:12
@ahoppen
Copy link
Member Author

ahoppen commented Jun 15, 2023

@swift-ci Please test

@ahoppen ahoppen changed the title Add missing trait conformances [5.9] Add missing trait conformances Jun 15, 2023
@ahoppen ahoppen merged commit f1e9245 into swiftlang:release/5.9 Jun 16, 2023
@ahoppen ahoppen deleted the ahoppen/5.9/missing-traits branch June 16, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants