Skip to content

Replace offset(of: ) with getOffsetToStart #1899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2023
Merged

Replace offset(of: ) with getOffsetToStart #1899

merged 1 commit into from
Jul 13, 2023

Conversation

StevenWong12
Copy link
Contributor

LexemeSequence.offset(of: ) and LexemeSequence.getOffsetToStart perform the same function and this should make the usage more consistent.

@StevenWong12 StevenWong12 requested a review from ahoppen as a code owner July 12, 2023 07:12
ahoppen
ahoppen reviewed Jul 12, 2023
View reviewed changes
@StevenWong12 StevenWong12 force-pushed the replace_offsetof_with_get_offset_to_start branch from 31b3cc1 to d0cca32 Compare July 12, 2023 12:28
ahoppen
ahoppen approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ahoppen
Copy link
Member

ahoppen commented Jul 13, 2023

@swift-ci Please test

@ahoppen ahoppen enabled auto-merge July 13, 2023 05:21
@ahoppen ahoppen merged commit 3481566 into swiftlang:main Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen ahoppen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StevenWong12 @ahoppen