Skip to content

Use rewrite func instead of visit for SyntaxRewriter #1939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Use rewrite func instead of visit for SyntaxRewriter #1939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Tests/PerformanceTest/VisitorPerformanceTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public class VisitorPerformanceTests: XCTestCase {
let emptyRewriter = EmptyRewriter(viewMode: .sourceAccurate)

try measureInstructions {
_ = emptyRewriter.visit(parsed)
_ = emptyRewriter.rewrite(parsed)
}
}

Expand Down
2 changes: 1 addition & 1 deletion Tests/SwiftOperatorsTest/OperatorTableTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ extension OperatorTable {

// Parse and "fold" the parenthesized version.
let parenthesizedParsed = Parser.parse(source: fullyParenthesizedSource)
let parenthesizedSyntax = ExplicitParenFolder(viewMode: .sourceAccurate).visit(parenthesizedParsed)
let parenthesizedSyntax = ExplicitParenFolder(viewMode: .sourceAccurate).rewrite(parenthesizedParsed)
XCTAssertFalse(parenthesizedSyntax.containsExprSequence)

// Make sure the two have the same structure.
Expand Down
2 changes: 1 addition & 1 deletion Tests/SwiftSyntaxBuilderTest/StringInterpolationTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ final class StringInterpolationTests: XCTestCase {
return DeclSyntax(newFunc)
}
}
let rewrittenSourceFile = Rewriter(viewMode: .sourceAccurate).visit(sourceFile)
let rewrittenSourceFile = Rewriter(viewMode: .sourceAccurate).rewrite(sourceFile)
XCTAssertEqual(
rewrittenSourceFile.description,
"""
Expand Down
6 changes: 3 additions & 3 deletions Tests/SwiftSyntaxTest/SyntaxVisitorTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ public class SyntaxVisitorTests: XCTestCase {
statements: CodeBlockItemListSyntax([])
)
let rewriter = ClosureRewriter(viewMode: .sourceAccurate)
let rewritten = rewriter.visit(closure)
let rewritten = rewriter.rewrite(closure)
XCTAssertEqual(closure.description, rewritten.description)
}

Expand Down Expand Up @@ -236,8 +236,8 @@ public class SyntaxVisitorTests: XCTestCase {
])
)
XCTAssertEqual(source.description, "let a = 5")
let visitor = TriviaRemover(viewMode: .sourceAccurate)
let rewritten = visitor.visit(source)
let rewriter = TriviaRemover(viewMode: .sourceAccurate)
let rewritten = rewriter.rewrite(source)
XCTAssertEqual(rewritten.description, "leta=5")
}
}