Perform a couple of renames on differentiability attribute nodes #1954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
bnbarham
approved these changes
Jul 27, 2023
Comment on lines
+54
to
+55
| message: "expected ':' and arguments in '@differentiable' argument", | ||
| fixIts: ["insert ':' and arguments"] |
There was a problem hiding this comment.
I guess this doesn't read any worse than before. But... it is a bit odd 😅. The problem is that Clause (containing wrt and Arguments), Arguments (which contains the parentheses), and ArgumentList (between the parentheses) all have basically the same name for diagnostics (+- an s).
There was a problem hiding this comment.
Yes. If there was more use of the @differentiable attribute, I would probably agree but for now, I’d suggest we keep it as-is.
Mostly change parameter to argument where the parameter is actually an argument.
ahoppen
force-pushed
the
ahoppen/rename-differentiability-nodes
branch
from
252d12c to
e6b437f
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly change parameter to argument where the parameter is actually an argument.