Skip to content

Make swift-syntax (mostly) build in Swift 6 mode #2531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Mar 6, 2024

This almost makes swift-syntax build in Swift 6 mode. The only change holding us back is that CommandLine.arguments is a static variable and accessing it in Swift 6 mode raises an error (rdar://113799564).

@ahoppen
Copy link
Member Author

ahoppen commented Mar 6, 2024

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Mar 6, 2024

@swift-ci Please test

This almost makes swift-syntax build in Swift 6 mode. The only change holding us back is that `CommandLine.arguments` is a static variable and accessing it in Swift 6 mode raises an error (rdar://113799564).
@ahoppen ahoppen force-pushed the ahoppen/build-with-swift-6 branch from b364137 to 7cb4358 Compare March 9, 2024 00:35
@ahoppen
Copy link
Member Author

ahoppen commented Mar 9, 2024

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Mar 9, 2024

@swift-ci Please test Windows

Copy link
Contributor

@bnbarham bnbarham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't say I'm a huge fan of the import condition, but I also have no better solution.

@ahoppen ahoppen merged commit fc656d5 into swiftlang:main Mar 11, 2024
@ahoppen ahoppen deleted the ahoppen/build-with-swift-6 branch March 11, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants