Address feedback, note ADO issue number for command line escaping

Author: grynspan

Sources/Testing/ExitTests/ExitTest.swift

@@ -71,7 +71,7 @@ public struct ExitTest: Sendable {
   /// - Returns: A file handle open for writing to which events should be
   ///   written, or `nil` if the file handle could not be resolved.
   private static func _findBackChannel() -> FileHandle? {
-    guard let backChannelEnvironmentVariable = Environment.variable(named: "SWT_EXPERIMENTAL_BACKCHANNEL_FD") else {
+    guard let backChannelEnvironmentVariable = Environment.variable(named: "SWT_EXPERIMENTAL_BACKCHANNEL") else {
       return nil
     }
 
@@ -407,7 +407,7 @@ extension ExitTest {
 #warning("Platform-specific implementation missing: back-channel pipe unavailable")
 #endif
         if let backChannelEnvironmentVariable {
-          childEnvironment["SWT_EXPERIMENTAL_BACKCHANNEL_FD"] = backChannelEnvironmentVariable
+          childEnvironment["SWT_EXPERIMENTAL_BACKCHANNEL"] = backChannelEnvironmentVariable
         }
 
         // Spawn the child process.

Sources/Testing/ExitTests/SpawnProcess.swift

@@ -157,7 +157,7 @@ func spawnExecutable(
     )
 
     let commandLine = _escapeCommandLine(CollectionOfOne(executablePath) + arguments)
-    let environ = environment.map { "\($0.key)=\($0.value)"}.joined(separator: "\0") + "\0\0"
+    let environ = environment.map { "\($0.key)=\($0.value)" }.joined(separator: "\0") + "\0\0"
 
     return try commandLine.withCString(encodedAs: UTF16.self) { commandLine in
       try environ.withCString(encodedAs: UTF16.self) { environ in
@@ -248,7 +248,8 @@ private func _withStartupInfoEx<R>(attributeCount: Int = 0, _ body: (UnsafeMutab
 /// Windows processes are responsible for handling their own command-line
 /// escaping. This function is adapted from the code in
 /// swift-corelibs-foundation (see `quoteWindowsCommandLine()`) which was
-/// itself adapted from code [published by Microsoft](https://learn.microsoft.com/en-us/archive/blogs/twistylittlepassagesallalike/everyone-quotes-command-line-arguments-the-wrong-way).
+/// itself adapted from code [published by Microsoft](https://learn.microsoft.com/en-us/archive/blogs/twistylittlepassagesallalike/everyone-quotes-command-line-arguments-the-wrong-way)
+/// (ADO 8992662).
 private func _escapeCommandLine(_ arguments: [String]) -> String {
   return arguments.lazy
     .map { arg in