Skip to content

Commit aa96a79

Browse files
authored
Remove the workaround for swift-package-manager-#8111. (#872)
Remove the workaround for swiftlang/swift-package-manager#8111. The issue has been resolved and Windows correctly exports symbols from dynamic library targets. ### Checklist: - [x] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [x] If public symbols are renamed or modified, DocC references should be updated.
1 parent 0e9bcba commit aa96a79

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

Package.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ let package = Package(
2828
products: [
2929
.library(
3030
name: "Testing",
31+
type: .dynamic, // needed so Windows exports ABI entry point symbols
3132
targets: ["Testing"]
3233
),
3334
],

Tests/TestingTests/ABIEntryPointTests.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,6 @@ struct ABIEntryPointTests {
129129
passing arguments: __CommandLineArguments_v0,
130130
recordHandler: @escaping @Sendable (_ recordJSON: UnsafeRawBufferPointer) -> Void = { _ in }
131131
) async throws -> Bool {
132-
#if !(!SWT_FIXED_SWIFTPM_8111 && os(Windows))
133132
#if !os(Linux) && !os(FreeBSD) && !os(Android) && !SWT_NO_DYNAMIC_LINKING
134133
// Get the ABI entry point by dynamically looking it up at runtime.
135134
//
@@ -143,7 +142,6 @@ struct ABIEntryPointTests {
143142
}
144143
)
145144
}
146-
#endif
147145
#endif
148146
let abiEntryPoint = unsafeBitCast(abiv0_getEntryPoint(), to: ABIv0.EntryPoint.self)
149147

0 commit comments

Comments
 (0)