Remove the introduced: 6.0 argument from the to-be-deprecated attributes on #expect(performing:throws:) and #require(performing:throws:).
#881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…butes on `#expect(performing:throws:)` and `#require(performing:throws:)`. The `introduced: 6.0` argument is causing the compiler to error out when building in earlier language modes. It isn't syntactically necessary and our DocC bundle provides the equivalent documentation info. So just drop it.
grynspan
added
bug
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci test |
|
@briancroom reviewed externally but didn't click the green button. Merging as self-reviewed! |
grynspan
deleted the
jgrynspan/remove-introduced-clauses-from-expect-throws-deprecation-attributes
branch
grynspan
added a commit
that referenced
this pull request
Jan 4, 2025
…butes on `#expect(performing:throws:)` and `#require(performing:throws:)`. (#881)
grynspan
added a commit
that referenced
this pull request
Jan 6, 2025
… attributes on `#expect(performing:throws:)` and `#require(performing:throws:)`. (#889) - **Explanation**: Fix spurious errors building with pre-6.0 language modes when using `#expect(performing:throws:)` or `#require(performing:throws:)`. - **Scope**: Tests written in 5.x language mode that use the to-be-deprecated expectation macros. - **Issues**: N/A - **Original PRs**: #881 - **Risk**: Low - **Testing**: Automated testing/tested at desk. - **Reviewers**: @briancroom @stmontgomery @SeanROlszewski @suzannaratcliff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
introduced: 6.0argument is causing the compiler to error out when building in earlier language modes. It isn't syntactically necessary and our DocC bundle provides the equivalent documentation info. So just drop it.Checklist: