TSCBasic: improve TemporaryFile on Windows

compnerd · compnerd · commit 741103477035 · 2020-08-09T17:32:30.000-07:00
Rather than using the ASCII version of the functions which prevent the
use of unicode characters in the path.  Given that `String` in Swift
internally will deal with the encoding, this allows us to encode to
UTF-16 and use the unicode version of the functions.
diff --git a/Sources/TSCBasic/TemporaryFile.swift b/Sources/TSCBasic/TemporaryFile.swift
@@ -135,7 +135,13 @@ public func withTemporaryFile<Result>(
     let tempFile = try TemporaryFile(dir: dir, prefix: prefix, suffix: suffix)
     defer {
         if deleteOnClose {
+#if os(Windows)
+            _ = tempFile.path.pathString.withCString(encodedAs: UTF16.self) {
+              _wunlink($0)
+            }
+#else
             unlink(tempFile.path.pathString)
+#endif
         }
     }
     return try body(tempFile)

Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,13 @@ public func withTemporaryFile<Result>(`
`135`	`135`	`let tempFile = try TemporaryFile(dir: dir, prefix: prefix, suffix: suffix)`
`136`	`136`	`defer {`
`137`	`137`	`if deleteOnClose {`
	`138`	`+#if os(Windows)`
	`139`	`+ _ = tempFile.path.pathString.withCString(encodedAs: UTF16.self) {`
	`140`	`+ _wunlink($0)`
	`141`	`+ }`
	`142`	`+#else`
`138`	`143`	`unlink(tempFile.path.pathString)`
	`144`	`+#endif`
`139`	`145`	`}`
`140`	`146`	`}`
`141`	`147`	`return try body(tempFile)`