Skip to content

Commit deee7c6

Browse files
committed
build: make SQLite a private dependency
Since the SQLite3 import is marked as `@_implementationOnly` this is perfectly reasonable to assume that the symbols from SQLite3 should not be required by consumers of this library and thus the consumers of this library do not need to link against SQLite3 themselves. Reflect this in the build. This is needed to ensure that the dependency handling works properly for building swift-driver.
1 parent 154af99 commit deee7c6

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

Sources/TSCUtility/CMakeLists.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,8 @@ add_library(TSCUtility
3939
)
4040
target_link_libraries(TSCUtility PUBLIC
4141
TSCBasic)
42+
target_link_libraries(TSCUtility PRIVATE
43+
SQLite::SQLite3)
4244
if(NOT CMAKE_SYSTEM_NAME STREQUAL Darwin)
4345
target_link_libraries(TSCUtility PUBLIC
4446
FoundationNetworking)

Sources/TSCclibc/CMakeLists.txt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,6 @@ add_library(TSCclibc STATIC
1111
target_include_directories(TSCclibc PUBLIC
1212
include)
1313

14-
target_link_libraries(TSCclibc PUBLIC
15-
SQLite::SQLite3)
16-
1714
if(NOT BUILD_SHARED_LIBS)
1815
install(TARGETS TSCclibc
1916
ARCHIVE DESTINATION lib)

0 commit comments

Comments
 (0)