Merge pull request #200 from neonichu/improve-tmpdir-error

neonichu · web-flow · commit fdb590046071 · 2021-03-22T23:34:27.000-07:00
Include the directory we tried in tmpDir error
diff --git a/Sources/TSCBasic/TemporaryFile.swift b/Sources/TSCBasic/TemporaryFile.swift
@@ -25,7 +25,7 @@ public enum TempFileError: Error {
     case other(Int32)
 
     /// Couldn't find a temporary directory.
-    case couldNotFindTmpDir
+    case couldNotFindTmpDir(String)
 }
 
 extension TempFileError: CustomNSError {
@@ -55,7 +55,7 @@ private extension TempFileError {
 public func determineTempDirectory(_ dir: AbsolutePath? = nil) throws -> AbsolutePath {
     let tmpDir = dir ?? cachedTempDirectory
     guard localFileSystem.isDirectory(tmpDir) else {
-        throw TempFileError.couldNotFindTmpDir
+        throw TempFileError.couldNotFindTmpDir(tmpDir.pathString)
     }
     return tmpDir
 }

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ public enum TempFileError: Error {`
`25`	`25`	`case other(Int32)`
`26`	`26`
`27`	`27`	`/// Couldn't find a temporary directory.`
`28`		`- case couldNotFindTmpDir`
	`28`	`+ case couldNotFindTmpDir(String)`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`extension TempFileError: CustomNSError {`
`@@ -55,7 +55,7 @@ private extension TempFileError {`
`55`	`55`	`public func determineTempDirectory(_ dir: AbsolutePath? = nil) throws -> AbsolutePath {`
`56`	`56`	`let tmpDir = dir ?? cachedTempDirectory`
`57`	`57`	`guard localFileSystem.isDirectory(tmpDir) else {`
`58`		`- throw TempFileError.couldNotFindTmpDir`
	`58`	`+ throw TempFileError.couldNotFindTmpDir(tmpDir.pathString)`
`59`	`59`	`}`
`60`	`60`	`return tmpDir`
`61`	`61`	`}`