Skip to content

Fix a build failure on Windows, where NAME_MAX doesn't exist #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix a build failure on Windows, where NAME_MAX doesn't exist #281

wants to merge 1 commit into from

Conversation

abertelrud
Copy link
Contributor

@abertelrud abertelrud commented Jan 13, 2022 •
edited
Loading

Motivation

Fix build break on Windows due to absence of NAME_MAX.

@abertelrud abertelrud requested a review from compnerd January 13, 2022 19:03
@abertelrud abertelrud self-assigned this Jan 13, 2022
@abertelrud abertelrud mentioned this pull request Jan 13, 2022
Closed
@abertelrud
Copy link
Contributor Author

@swift-ci test

compnerd
compnerd requested changes Jan 13, 2022
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still breaks, I think I have a fix, I'll upload it in a minute.

@abertelrud
Copy link
Contributor Author

This still breaks, I think I have a fix, I'll upload it in a minute.

Thanks. I think I just need to wrap the unit test in a condition too.

@abertelrud abertelrud force-pushed the eng/adjust-filelock-fix-for-windows branch from 7ac80cc to be3f4d0 Compare January 13, 2022 19:14
@abertelrud
Copy link
Contributor Author

@compnerd Conditionalized the unit test too. That should be it.

@abertelrud
Copy link
Contributor Author

@swift-ci please test

@abertelrud
Copy link
Contributor Author

We do have other uses of NAME_MAX, but I didn't notice that they're inside big conditionals.

@compnerd compnerd mentioned this pull request Jan 13, 2022
Merged
@abertelrud
Copy link
Contributor Author

Withdrawing this — it has been superseded by #282

@abertelrud abertelrud closed this Jan 13, 2022
@compnerd compnerd deleted the eng/adjust-filelock-fix-for-windows branch January 13, 2022 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd requested changes

@aciidgh aciidgh Awaiting requested review from aciidgh

@friedbunny friedbunny Awaiting requested review from friedbunny

@neonichu neonichu Awaiting requested review from neonichu

@tomerd tomerd Awaiting requested review from tomerd

Assignees

@abertelrud abertelrud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abertelrud @compnerd