Skip to content

Fix Git discovery & execution on Windows #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2020
Merged

Fix Git discovery & execution on Windows #96

merged 1 commit into from
Aug 3, 2020

Conversation

egorzhdan
Copy link
Contributor

This fixes:

  • git discovery by searching for git.exe instead of git
  • git invocation by passing an absolute path instead of just an executable name

For an example of usage please see GitRepositoryProvider.fetch in the SwiftPM project.

aciidgh
aciidgh reviewed Jul 30, 2020
View reviewed changes
@aciidgh
Copy link
Contributor

aciidgh commented Jul 30, 2020

@swift-ci smoke test

@MaxDesiatov
Copy link
Contributor

@swift-ci please test

@MaxDesiatov MaxDesiatov merged commit 266a491 into swiftlang:master Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aciidgh aciidgh aciidgh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@egorzhdan @aciidgh @MaxDesiatov