Skip to content

Fix build on Windows #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 9, 2020
Merged

Fix build on Windows #98

merged 3 commits into from
Aug 9, 2020

Conversation

egorzhdan
Copy link
Contributor

@egorzhdan egorzhdan commented Aug 6, 2020 •
edited
Loading

  • SQLite3 was recently added as a dependency, and CMake build scripts needed a couple of fixes
  • dirent is not available on Windows
  • TSCUtility.dll was not copied into the installation directory

@egorzhdan egorzhdan mentioned this pull request Aug 6, 2020
Merged
@MaxDesiatov
Copy link
Contributor

@swift-ci please test

MaxDesiatov
MaxDesiatov approved these changes Aug 9, 2020
View reviewed changes
Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaxDesiatov MaxDesiatov merged commit f0017d7 into swiftlang:master Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@egorzhdan @MaxDesiatov