[Tracing] Include task name, isDiscarding, hasExPreference in tracing

Author: ktoso

stdlib/public/Concurrency/Task.cpp

@@ -1131,12 +1131,14 @@ swift_task_create_commonImpl(size_t rawTaskCreateFlags,
   }
 
   // FIXME: add discarding flag
-  // FIXME: add task executor
   concurrency::trace::task_create(
       task, parent, group, asyncLet,
       static_cast<uint8_t>(task->Flags.getPriority()),
       task->Flags.task_isChildTask(), task->Flags.task_isFuture(),
-      task->Flags.task_isGroupChildTask(), task->Flags.task_isAsyncLetTask());
+      task->Flags.task_isGroupChildTask(), task->Flags.task_isAsyncLetTask(),
+      taskCreateFlags.isDiscardingTask(),
+      task->Flags.task_hasInitialTaskExecutorPreference(),
+      taskName);
 
   // Attach to the group, if needed.
   if (group) {

stdlib/public/Concurrency/TracingSignpost.h

@@ -182,7 +182,9 @@ inline void actor_note_job_queue(HeapObject *actor, Job *first,
 inline void task_create(AsyncTask *task, AsyncTask *parent, TaskGroup *group,
                         AsyncLet *asyncLet, uint8_t jobPriority,
                         bool isChildTask, bool isFuture, bool isGroupChildTask,
-                        bool isAsyncLetTask) {
+                        bool isAsyncLetTask, bool isDiscardingTask,
+                        bool hasInitialTaskExecutorPreference,
+                        const char* taskName) {
   ENSURE_LOGS();
   auto id = os_signpost_id_make_with_pointer(TaskLog, task);
   auto parentID = parent ? parent->getTaskId() : 0;
@@ -191,10 +193,12 @@ inline void task_create(AsyncTask *task, AsyncTask *parent, TaskGroup *group,
       "task=%" PRIx64
       " resumefn=%p jobPriority=%u isChildTask=%{bool}d, isFuture=%{bool}d "
       "isGroupChildTask=%{bool}d isAsyncLetTask=%{bool}d parent=%" PRIx64
-      " group=%p asyncLet=%p",
+      " group=%p asyncLet=%p "
+      "isDiscardingTask=%{bool}d hasInitialTaskExecutorPreference=%{bool}d "
+      "taskName=%{public}s",
       task->getTaskId(), task->getResumeFunctionForLogging(true), jobPriority,
       isChildTask, isFuture, isGroupChildTask, isAsyncLetTask, parentID, group,
-      asyncLet);
+      asyncLet, isDiscardingTask, hasInitialTaskExecutorPreference, taskName);
 }
 
 inline void task_destroy(AsyncTask *task) {

stdlib/public/Concurrency/TracingStubs.h

@@ -44,12 +44,13 @@ inline void actor_note_job_queue(HeapObject *actor, Job *first,
 inline void task_create(AsyncTask *task, AsyncTask *parent, TaskGroup *group,
                         AsyncLet *asyncLet, uint8_t jobPriority,
                         bool isChildTask, bool isFuture, bool isGroupChildTask,
-                        bool isAsyncLetTask) {}
+                        bool isAsyncLetTask, bool isDiscardingTask,
+                        bool hasInitialTaskExecutorPreference,
+                        const char* taskName) {}
 
 inline void task_destroy(AsyncTask *task) {}
 
-inline void task_wait(AsyncTask *task, AsyncTask *waitingOn, uintptr_t status) {
-}
+inline void task_wait(AsyncTask *task, AsyncTask *waitingOn, uintptr_t status) {}
 
 inline void task_resume(AsyncTask *task) {}