Support for address based array initialization under opaque values mode

Author: Joe Shajrawi

lib/SILGen/SILGenApply.cpp

@@ -2965,16 +2965,18 @@ namespace {
       // it's not already there.  (Note that this potentially includes
       // conventions which pass indirectly without transferring
       // ownership, like Itanium C++.)
-      if (SGF.silConv.isSILIndirect(param)) {
-        if (specialDest) {
-          emitIndirectInto(std::move(arg), origParamType,
-                           loweredSubstParamType, *specialDest);
-          Args.push_back(ManagedValue::forInContext());
-        } else {
-          auto value = emitIndirect(std::move(arg), loweredSubstArgType,
-                                    origParamType, param);
-          Args.push_back(value);
-        }
+      if (specialDest) {
+        assert(param.isFormalIndirect() &&
+               "SpecialDest should imply indirect parameter");
+        // TODO: Change the way we initialize array storage in opaque mode
+        emitIndirectInto(std::move(arg), origParamType, loweredSubstParamType,
+                         *specialDest);
+        Args.push_back(ManagedValue::forInContext());
+        return;
+      } else if (SGF.silConv.isSILIndirect(param)) {
+        auto value = emitIndirect(std::move(arg), loweredSubstArgType,
+                                  origParamType, param);
+        Args.push_back(value);
         return;
       }
 

test/SILGen/opaque_values_silgen.swift

@@ -8,6 +8,24 @@ protocol P {
   var x : Int { get }
 }
 
+func hasVarArg(_ args: Any...) {}
+
+// Test that we still use addresses when dealing with array initialization
+// ---
+// CHECK-LABEL: sil @_TF20opaque_values_silgen10callVarArgFT_T_ : $@convention(thin) () -> () {
+// CHECK: %[[APY:.*]] = apply %{{.*}}<Any>(%{{.*}}) : $@convention(thin) <τ_0_0> (Builtin.Word) -> (@owned Array<τ_0_0>, Builtin.RawPointer)
+// CHECK: %[[BRW:.*]] = begin_borrow %[[APY]]
+// CHECK: %[[TPL:.*]] = tuple_extract %[[BRW]] : $(Array<Any>, Builtin.RawPointer), 1
+// CHECK: end_borrow %[[BRW]] from %[[APY]] : $(Array<Any>, Builtin.RawPointer), $(Array<Any>, Builtin.RawPointer)
+// CHECK: destroy_value %[[APY]]
+// CHECK: %[[PTR:.*]] = pointer_to_address %[[TPL]] : $Builtin.RawPointer to [strict] $*Any
+// CHECK: init_existential_addr %[[PTR]] : $*Any, $Int
+// CHECK: return %{{.*}} : $()
+// CHECK: } // end sil function '_TF20opaque_values_silgen10callVarArgFT_T_'
+public func callVarArg() {
+  hasVarArg(3)
+}
+
 // Test emitSemanticStore.
 // ---
 // CHECK-LABEL: sil hidden @_TF20opaque_values_silgen11assigninouturFTRxx_T_ : $@convention(thin) <T> (@inout T, @in T) -> () {

test/SILGen/opaque_values_silgen_todo.swift

@@ -1,9 +1,2 @@
 // RUN: %target-swift-frontend -enable-sil-opaque-values -emit-sorted-sil -Xllvm -sil-full-demangle -emit-silgen %s | %FileCheck %s
 // REQUIRES: EnableSILOpaqueValues
-
-func hasVarArg(_ args: Any...) {}
-
-// ArgEmitter: fix SpecialDest args.
-public func callVarArg() {
-  hasVarArg(3)
-}