SILGen: Diagnose invalid captures of top-level bindings

A method of a nominal type is not allowed to capture anything.
If we did compute a capture list, clear it out to preserve
downstream invariants.

This can happen because not all invalid captures involving
nominal types in local context can be diagnosed in Sema.

In particular, we allow a method of a local type to
reference a local function from an outer scope, as long as
that local function does not have any (transitive) captures.
Since Sema cannot validate the latter condition, it punts
and allows any reference to a FuncDecl in local context.

When emitting the captures in this situation, SILGen will
diagnose the problem using the existing 'forward reference'
logic.

The diagnostic is sub-optimal -- it should talk about a
reference from inside a local type, and not a 'forward
reference'. But still better than crashing.

Author: slavapestov

lib/SIL/TypeLowering.cpp

@@ -2392,6 +2392,15 @@ TypeConverter::getLoweredLocalCaptures(SILDeclRef fn) {
     resultingCaptures.push_back(*selfCapture);
   }
 
+  // It is an error for a member of a nominal type to have any captures
+  // at all. If we just clear them out here, SILGen will diagnose the
+  // problem.
+  if (fn.hasDecl()) {
+    auto *dc = fn.getDecl()->getDeclContext();
+    if (dc->isTypeContext())
+      resultingCaptures.clear();
+  }
+
   // Cache the uniqued set of transitive captures.
   CaptureInfo info{Context, resultingCaptures, capturesDynamicSelf,
                    capturesOpaqueValue, capturesGenericParams};

test/SILGen/nested_types_referencing_nested_functions.swift

@@ -1,5 +1,5 @@
 
-// RUN: %target-swift-emit-silgen -module-name nested_types_referencing_nested_functions %s | %FileCheck %s
+// RUN: %target-swift-emit-silgen -verify -module-name nested_types_referencing_nested_functions %s | %FileCheck %s
 
 do {
   func foo() { bar(2) }
@@ -32,3 +32,19 @@ do {
   _ = x.zim
   _ = x.zang as (Int) -> ()
 }
+
+// Invalid case
+do {
+  var x = 123 // expected-note {{captured value declared here}}
+
+  func local() {
+    // expected-error@-1 {{closure captures 'x' before it is declared}}
+    _ = x // expected-note {{captured here}}
+  }
+
+  class Bar {
+    func zang() {
+      local()
+    }
+  }
+}