Merge pull request #31133 from zoecarver/lva/dead-access

Author: swift-ci

lib/SILOptimizer/Transforms/DeadCodeElimination.cpp

@@ -40,6 +40,11 @@ namespace {
 // FIXME: Reconcile the similarities between this and
 //        isInstructionTriviallyDead.
 static bool seemsUseful(SILInstruction *I) {
+  // begin_access is defined to have side effects, but this is not relevant for
+  // DCE.
+  if (isa<BeginAccessInst>(I))
+    return false;
+
   if (I->mayHaveSideEffects())
     return true;
 
@@ -258,6 +263,10 @@ void DCE::markLive(SILFunction &F) {
         }
         continue;
       }
+      if (auto *endAccess = dyn_cast<EndAccessInst>(&I)) {
+        addReverseDependency(endAccess->getBeginAccess(), &I);
+        continue;
+      }
       if (seemsUseful(&I))
         markValueLive(&I);
     }

test/SILOptimizer/dead_code_elimination.sil

@@ -259,3 +259,21 @@ bb2:
 bb3:
   br bb1
 }
+
+// Check that DCE eliminates dead access instructions.
+// CHECK-LABEL: sil @dead_access
+// CHECK: bb0
+// CHECK-NEXT: tuple
+// CHECK-NEXT: return
+// CHECK-LABEL: end sil function 'dead_access'
+sil @dead_access : $@convention(thin) (@in Container) -> () {
+bb0(%0 : $*Container):
+  %1 = begin_access [modify] [dynamic] %0 : $*Container
+  end_access %1 : $*Container
+  
+  %3 = begin_access [read] [static] %0 : $*Container
+  end_access %3 : $*Container
+
+  %999 = tuple ()
+  return %999 : $()
+}