Skip to content

Commit 05d4aa0

Browse files
committed
Next step in connecting libdispatch and foundation builds
Three small changes for building libdispatch and foundation together. (1) Put libdispatch into PRODUCTS before foundation (2) Pass path to swift down into libdispatch build (3) Pass paths to libdispatch down into foundation build
1 parent 99b0e77 commit 05d4aa0

File tree

1 file changed

+12
-5
lines changed

1 file changed

+12
-5
lines changed

utils/build-script-impl

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -926,12 +926,12 @@ fi
926926
if [[ ! "${SKIP_BUILD_XCTEST}" ]] ; then
927927
PRODUCTS=("${PRODUCTS[@]}" xctest)
928928
fi
929-
if [[ ! "${SKIP_BUILD_FOUNDATION}" ]] ; then
930-
PRODUCTS=("${PRODUCTS[@]}" foundation)
931-
fi
932929
if [[ ! "${SKIP_BUILD_LIBDISPATCH}" ]] ; then
933930
PRODUCTS=("${PRODUCTS[@]}" libdispatch)
934931
fi
932+
if [[ ! "${SKIP_BUILD_FOUNDATION}" ]] ; then
933+
PRODUCTS=("${PRODUCTS[@]}" foundation)
934+
fi
935935

936936
SWIFT_STDLIB_TARGETS=()
937937
SWIFT_PERFTEST_TARGETS=()
@@ -1801,6 +1801,12 @@ for deployment_target in "${HOST_TARGET}" "${CROSS_TOOLS_DEPLOYMENT_TARGETS[@]}"
18011801
LLVM_BIN="$(build_directory_bin ${deployment_target} llvm)"
18021802
NINJA_BIN="ninja"
18031803

1804+
# Staging: require opt-in for building with dispatch
1805+
if [[ ! "${SKIP_BUILD_LIBDISPATCH}" ]] ; then
1806+
LIBDISPATCH_BUILD_DIR="$(build_directory ${deployment_target} libdispatch)"
1807+
LIBDISPATCH_BUILD_ARGS="-DLIBDISPATCH_SOURCE_DIR=${LIBDISPATCH_SOURCE_DIR} -DLIBDISPATCH_BUILD_DIR=${LIBDISPATCH_BUILD_DIR}"
1808+
fi
1809+
18041810
if [[ "${BUILD_NINJA}" ]]; then
18051811
NINJA_BUILD_DIR=$(build_directory build ninja)
18061812
NINJA_BIN="${NINJA_BUILD_DIR}/ninja"
@@ -1809,7 +1815,7 @@ for deployment_target in "${HOST_TARGET}" "${CROSS_TOOLS_DEPLOYMENT_TARGETS[@]}"
18091815
set -x
18101816
pushd "${FOUNDATION_SOURCE_DIR}"
18111817
SWIFTC="${SWIFTC_BIN}" CLANG="${LLVM_BIN}"/clang SWIFT="${SWIFT_BIN}" \
1812-
SDKROOT="${SWIFT_BUILD_PATH}" BUILD_DIR="${build_dir}" DSTROOT="${INSTALL_DESTDIR}" PREFIX="${INSTALL_PREFIX}" ./configure "${FOUNDATION_BUILD_TYPE}" -DXCTEST_BUILD_DIR=${XCTEST_BUILD_DIR}
1818+
SDKROOT="${SWIFT_BUILD_PATH}" BUILD_DIR="${build_dir}" DSTROOT="${INSTALL_DESTDIR}" PREFIX="${INSTALL_PREFIX}" ./configure "${FOUNDATION_BUILD_TYPE}" -DXCTEST_BUILD_DIR=${XCTEST_BUILD_DIR} $LIBDISPATCH_BUILD_ARGS
18131819
${NINJA_BIN}
18141820
popd
18151821
{ set +x; } 2>/dev/null
@@ -1819,6 +1825,7 @@ for deployment_target in "${HOST_TARGET}" "${CROSS_TOOLS_DEPLOYMENT_TARGETS[@]}"
18191825
;;
18201826
libdispatch)
18211827
LIBDISPATCH_BUILD_DIR=$(build_directory ${deployment_target} ${product})
1828+
SWIFT_BUILD_PATH="$(build_directory ${deployment_target} swift)"
18221829

18231830
set -x
18241831
if [[ ! -f "${LIBDISPATCH_BUILD_DIR}"/config.status ]]; then
@@ -1828,7 +1835,7 @@ for deployment_target in "${HOST_TARGET}" "${CROSS_TOOLS_DEPLOYMENT_TARGETS[@]}"
18281835
autoreconf -fvi
18291836
popd
18301837
pushd "${LIBDISPATCH_BUILD_DIR}"
1831-
"${LIBDISPATCH_SOURCE_DIR}"/configure --prefix="${INSTALL_DESTDIR}"/"${INSTALL_PREFIX}"
1838+
"${LIBDISPATCH_SOURCE_DIR}"/configure --prefix="${INSTALL_DESTDIR}"/"${INSTALL_PREFIX}" --with-swift-toolchain="${SWIFT_BUILD_PATH}"
18321839
popd
18331840
fi
18341841
pushd "${LIBDISPATCH_BUILD_DIR}"

0 commit comments

Comments
 (0)