Skip to content

Commit 067f475

Browse files
committed
Comment some TODO items
1 parent 1024c4f commit 067f475

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

benchmark/scripts/compare_perf_tests.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -188,6 +188,7 @@ def fromJSONFormat(cls, line):
188188
return PerformanceTestResult(json_data)
189189

190190
def __init__(self, json_data):
191+
# Ugly hack to get the old tests to run
191192
if isinstance(json_data, str):
192193
json_data = json.loads(json_data)
193194

@@ -449,6 +450,17 @@ def __init__(self, old, new):
449450
ratio = (new.min_value + 0.001) / (old.min_value + 0.001)
450451
self.delta = (ratio - 1) * 100
451452

453+
454+
# If we have full samples for both old and new...
455+
if (len(old.samples) == old.num_samples
456+
and len(new.samples) == new.num_samples):
457+
# TODO: Use a T-Test or U-Test to determine whether
458+
# one set of samples should be considered reliably better than
459+
# the other.
460+
None
461+
462+
# If we do not have full samples, we'll use the
463+
# legacy calculation for compatibility.
452464
# Indication of dubious changes: when result's MIN falls inside the
453465
# (MIN, MAX) interval of result they are being compared with.
454466
self.is_dubious = (

0 commit comments

Comments
 (0)