Sema: Convert to rvalue type before diagnosing protocol type member failure

sl · sl · commit 0714dfe6074c · 2019-05-30T18:35:20.000-04:00
diff --git a/lib/Sema/CSDiagnostics.cpp b/lib/Sema/CSDiagnostics.cpp
@@ -1978,7 +1978,7 @@ bool AllowProtocolTypeMemberFailure::diagnoseAsError() {
   }
 
   emitDiagnostic(getAnchor()->getLoc(),
-                 diag::could_not_use_member_on_existential, getBaseType(),
+                 diag::could_not_use_member_on_existential, getBaseType()->getRValueType(),
                  getName())
       .highlight(nameLoc.getSourceRange())
       .highlight(baseExpr->getSourceRange());

Original file line number	Diff line number	Diff line change
`@@ -1978,7 +1978,7 @@ bool AllowProtocolTypeMemberFailure::diagnoseAsError() {`
`1978`	`1978`	`}`
`1979`	`1979`
`1980`	`1980`	`emitDiagnostic(getAnchor()->getLoc(),`
`1981`		`- diag::could_not_use_member_on_existential, getBaseType(),`
	`1981`	`+ diag::could_not_use_member_on_existential, getBaseType()->getRValueType(),`
`1982`	`1982`	`getName())`
`1983`	`1983`	`.highlight(nameLoc.getSourceRange())`
`1984`	`1984`	`.highlight(baseExpr->getSourceRange());`