Skip to content

Commit 072e19c

Browse files
committed
Merge remote-tracking branch 'origin/main' into rebranch
2 parents cf66a37 + 3dc24b8 commit 072e19c

File tree

2 files changed

+2
-10
lines changed

2 files changed

+2
-10
lines changed

utils/swift_build_support/swift_build_support/products/wasisysroot.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -58,20 +58,11 @@ def _build(self, host_target, thread_model='single', target_triple='wasm32-wasi'
5858

5959
sysroot_build_dir = WASILibc.sysroot_build_path(
6060
build_root, host_target, target_triple)
61-
# FIXME: Manually create an empty dir that is usually created during
62-
# check-symbols. The directory is required during sysroot installation step.
63-
os.makedirs(os.path.join(sysroot_build_dir, "share"), exist_ok=True)
6461

6562
sysroot_install_path = WASILibc.sysroot_install_path(build_root, target_triple)
6663
shell.call([
6764
'make', 'install',
6865
'-j', str(build_jobs),
69-
# FIXME: wasi-libc's pre-defined macro list does not expect
70-
# `__FPCLASS_XXX`, which is introduced by the LLVM 17, yet.
71-
# So skip the symbol check step by treating the phony target
72-
# as very old file.
73-
# https://github.com/llvm/llvm-project/commit/7dd387d2971d7759cadfffeb2082439f6c7ddd49
74-
'--old-file=check-symbols',
7566
'-C', self.source_dir,
7667
'OBJDIR=' + os.path.join(self.build_dir, 'obj-' + thread_model),
7768
'SYSROOT=' + sysroot_build_dir,

utils/update_checkout/update_checkout/update_checkout.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
import sys
1717
import traceback
1818
from multiprocessing import Lock, Pool, cpu_count, freeze_support
19+
from typing import Optional
1920

2021
from build_swift.build_swift.constants import SWIFT_SOURCE_ROOT
2122

@@ -74,7 +75,7 @@ def check_parallel_results(results, op):
7475
return fail_count
7576

7677

77-
def confirm_tag_in_repo(tag, repo_name):
78+
def confirm_tag_in_repo(tag, repo_name) -> Optional[str]:
7879
# type: (str, str) -> str | None
7980
"""Confirm that a given tag exists in a git repository. This function
8081
assumes that the repository is already a current working directory before

0 commit comments

Comments
 (0)