Gardening: Migrate test suite to GH issues: SILOptimizer (2/2)

Author: AnthonyLatsis

test/SILOptimizer/exclusivity_static_diagnostics.sil

@@ -1064,11 +1064,15 @@ bb0(%0 : @guaranteed $ClassWithStoredProperty, %1 : $Int32):
   return %v : $()
 }
 
-// <rdar://problem/41976355> [SR-8201]: Swift 4.2 Crash in DiagnoseStaticExclusivity (llvm_unreachable)
-// mutatingNoescapeWithThunk and mutatingNoescapeConflictWithThunk.
-// Test that noescape closure verification allows a closure with @inout_aliasable argument convention,
-// which may only be used as a nonescaping closure, can be passed to a reabstraction thunk
-// without the @noescape function-type argument convention.
+// rdar://problem/41976355
+// https://github.com/apple/swift/issues/50733
+// Swift 4.2 crash in 'DiagnoseStaticExclusivity' (llvm_unreachable)
+//
+// Test that '@noescape' closure verification allows a closure with
+// '@inout_aliasable' argument convention, which may only be used as a
+// nonescaping closure, to be passed to a reabstraction thunk without the
+// '@noescape' function-type argument convention ('mutatingNoescapeWithThunk'
+// and 'mutatingNoescapeConflictWithThunk').
 
 sil [ossa] @mutatingNoescapeHelper : $@convention(thin) (Optional<UnsafePointer<Int32>>, @inout_aliasable Int32) -> () {
 bb0(%0 : $Optional<UnsafePointer<Int32>>, %1 : $*Int32):
@@ -1206,16 +1210,18 @@ bb3(%block : @owned $@convention(block) @noescape () -> ()):
 }
 
 // -----------------------------------------------------------------------------
-// <rdar://problem/42242406> [SR-8266]: Compiler crash when checking
-// exclusivity of inout alias:
+// rdar://problem/42242406
+// https://github.com/apple/swift/issues/50797
+// Compiler crash when checking exclusivity of 'inout' alias
+//
+// Test that 'checkNoEscapePartialApply' does not assert on a '@noescape'
+// closure passed through a block argument:
+//
 // closureWithNoCapture
-// closureWithConflict,
+// closureWithConflict
 // partialApplyPhiThunk
-// testPartialApplyPhi.
-// testDirectPartialApplyPhi.
-//
-// Test that 'checkNoEscapePartialApply' does not assert on a noescape
-// closure passed through a block argument.
+// testPartialApplyPhi
+// testDirectPartialApplyPhi
 
 sil hidden [ossa] @closureWithNoCapture : $@convention(thin) (Int) -> () {
 bb0(%0 : $Int):

test/SILOptimizer/exclusivity_static_diagnostics.swift

@@ -619,7 +619,11 @@ func nestedConflict(x: inout Int) {
 // Avoid diagnosing a conflict on disjoint struct properies when one is a `let`.
 // This requires an address projection before loading the `let` property.
 //
-// <rdar://problem/35561050> [SR-10145][Exclusivity] SILGen loads entire struct when reading captured 'let' stored property
+// rdar://problem/35561050
+// https://github.com/apple/swift/issues/52547
+// [Exclusivity] SILGen loads entire struct when reading captured 'let'
+// stored property
+
 struct DisjointLetMember {
   var dummy: AnyObject // Make this a nontrivial struct because the SIL is more involved.
   mutating func get(makeValue: ()->Int) -> Int {

test/SILOptimizer/existential_specializer_soletype.sil

@@ -383,8 +383,11 @@ bb0(%0 : $S, %1 : $*P):
 
 //===----------------------------------------------------------------------===//
 // Test an existential with a generic constraint
-// rdar://56923071; [SR-11714]: Compiler crash when generic class is passed as
-// a parameter to a function accepting a generic class
+//
+// rdar://56923071
+// https://github.com/apple/swift/issues/54123
+// Compiler crash when generic class is passed as a parameter to a function
+// accepting a generic class
 //
 // Allowing this results in the error:
 // SIL verification failed: Operand is of an ArchetypeType that does not exist

test/SILOptimizer/sr-4957.swift renamed to test/SILOptimizer/issue-47534.swift

@@ -1,3 +1,5 @@
 // RUN: %target-swift-frontend -O -emit-sil -primary-file %s %S/Inputs/extension-with-nested-type.swift -module-name test
 
+// https://github.com/apple/swift/issues/47534
+
 // Intentionally empty.

test/SILOptimizer/sr-5068.sil renamed to test/SILOptimizer/issue-47644.sil

@@ -2,6 +2,8 @@
 
 // REQUIRES: PTRSIZE=64
 
+// https://github.com/apple/swift/issues/47644
+
 sil_stage canonical
 
 import Builtin

test/SILOptimizer/let_properties_opts.sil

@@ -6,7 +6,9 @@ import Builtin
 import Swift
 
 // Test initialization of a constant aggregate "let".
-// <rdar://problem/45691574> [SR-9146] IBAnimatable - SILCloner crash in LetPropertiesOpt.
+// rdar://problem/45691574
+// https://github.com/apple/swift/issues/51642
+// IBAnimatable - 'SILCloner' crash in 'LetPropertiesOpt'
 
 struct Point {
   var x: Int64

test/SILOptimizer/return.swift

@@ -159,8 +159,8 @@ struct StructWithIUOinit : InitProtocol {
   init!(_ x: Int) {  } // no missing-return error
 }
 
-func testSR13753() {
-  // SR-13753
+// https://github.com/apple/swift/issues/56150
+func f_56150() {
   let _ : () -> Int = {
     var x : Int {
       get { 0 }
@@ -217,8 +217,9 @@ func testSR13753() {
   }
 }
 
-// SR-14505
-struct SR14505 {
+// https://github.com/apple/swift/issues/56857
+
+struct S_56857 {
     let b = true
     var x: Int {
         if b {
@@ -236,7 +237,7 @@ struct SR14505 {
     } 
 }
 
-class SR14505_C {
+class C_56857 {
   static let a = false
   let b = true
 

test/SILOptimizer/sil_combine_concrete_existential.sil

@@ -18,9 +18,10 @@ import SwiftShims
 // SILCombine should bailout since it does not propagate
 // type substitutions on the return value.
 //
-// <rdar://40555427> [SR-7773]:
-// SILCombiner::propagateConcreteTypeOfInitExistential fails to full propagate
-// type substitutions.
+// rdar://40555427
+// https://github.com/apple/swift/issues/50312
+// 'SILCombiner::propagateConcreteTypeOfInitExistential' fails to fully
+// propagate type substitutions.
 //===----------------------------------------------------------------------===//
 public protocol P : AnyObject {
 }
@@ -722,7 +723,9 @@ bb3(%20 : $Error):
 }
 
 // -----------------------------------------------------------------------------
-// rdar://88664423 (SR-15791: Miscompile under -O with mutating protocol method)
+// rdar://88664423
+// https://github.com/apple/swift/issues/58068
+// Miscompile under -O with mutating protocol method
 //
 // Basic outline (test case has more copies):
 //   %1 = alloc_stack $PPP

test/SILOptimizer/sil_combine_concrete_existential.swift

@@ -7,9 +7,10 @@
 // sil-combine should bailout since it does not propagate
 // type substitutions on the return value.
 //
-// <rdar://40555427> [SR-7773]:
-// SILCombiner::propagateConcreteTypeOfInitExistential fails to full propagate
-// type substitutions.
+// rdar://40555427
+// https://github.com/apple/swift/issues/50312
+// 'SILCombiner::propagateConcreteTypeOfInitExistential' fails to fully
+// propagate type substitutions.
 //===----------------------------------------------------------------------===//
 public protocol P: class {}
 

test/SILOptimizer/sil_combine_objc.sil

@@ -1,6 +1,6 @@
 // RUN: %target-sil-opt -enable-objc-interop -enable-sil-verify-all %s -sil-combine | %FileCheck %s
 
-// See https://bugs.swift.org/browse/SR-5065, rdar://32511494
+// https://github.com/apple/swift/issues/47641, rdar://32511494
 // XFAIL: *
 
 sil_stage canonical

test/SILOptimizer/sil_combine_objc_ossa.sil

@@ -1,6 +1,6 @@
 // RUN: %target-sil-opt -enable-objc-interop -enable-sil-verify-all %s -sil-combine | %FileCheck %s
 
-// See https://bugs.swift.org/browse/SR-5065, rdar://32511494
+// See https://github.com/apple/swift/issues/47641, rdar://32511494
 // XFAIL: *
 
 sil_stage canonical

test/SILOptimizer/silcombine_runtime_crash.swift

@@ -5,7 +5,7 @@
 
 // REQUIRES: executable_test
 
-// This is an end-to-end test for SR-9627.
+// This is an end-to-end test for https://github.com/apple/swift/issues/52073.
 
 @inline(never)
 func save(value: Double?) {

test/SILOptimizer/simplify_cfg_simple.sil

@@ -36,7 +36,10 @@ bb3:
 // Test that SimplifyCFG::simplifyBlocks, tryJumpThreading does not
 // perform unbounded loop peeling.
 //
-// rdar://73357726 ([SR-14068]: Compiling with optimisation runs indefinitely for grpc-swift)
+// rdar://73357726
+// https://github.com/apple/swift/issues/56457
+// Compiling with optimisation runs indefinitely for grpc-swift
+//
 // CHECK-LABEL: sil @testInfinitePeeling : $@convention(method) (Builtin.Int64, Enum) -> () {
 //
 // There is only one switch_enum blocks, and it is no longer in a loop.

test/SILOptimizer/simplify_cfg_trivial_jumpthread.sil

@@ -20,7 +20,9 @@ enum BoolLike { case true_, false_ }
 // Test that SimplifyCFG::simplifyBlocks, tryJumpThreading does not
 // perform unbounded loop peeling.
 //
-// rdar://73357726 ([SR-14068]: Compiling with optimisation runs indefinitely for grpc-swift)
+// rdar://73357726
+// https://github.com/apple/swift/issues/56457
+// Compiling with optimisation runs indefinitely for grpc-swift
 //
 // Note: this no longer attempts to run jump-threading infinitely, so
 // does not actually unit test the bailout. But it is still an

test/SILOptimizer/stack_promotion_crash.swift

@@ -7,7 +7,7 @@
 
 // Check that the compiled code does not crash because of a wrong
 // stack-promoted array.
-// End-to-end test for https://bugs.swift.org/browse/SR-10444
+// End-to-end test for https://github.com/apple/swift/issues/52844.
 
 public struct Beta {
   var gamma: [Int]

test/SILOptimizer/unused_containers.swift

@@ -2,11 +2,11 @@
 
 // REQUIRES: swift_stdlib_no_asserts
 
-// FIXME: https://bugs.swift.org/browse/SR-7806
+// FIXME: https://github.com/apple/swift/issues/50345
 // REQUIRES: CPU=arm64 || CPU=x86_64
 // REQUIRES: rdar45797168
 
-// FIXME: https://bugs.swift.org/browse/SR-9008
+// FIXME: https://github.com/apple/swift/issues/51511
 
 //CHECK-LABEL: @$s17unused_containers16empty_array_testyyF
 //CHECK: bb0: