Skip to content

Commit 0bccd8d

Browse files
committed
Address review feedback
1 parent db88d43 commit 0bccd8d

File tree

1 file changed

+4
-5
lines changed
  • utils/swift_build_support/swift_build_support/products

1 file changed

+4
-5
lines changed

utils/swift_build_support/swift_build_support/products/benchmarks.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ def _get_test_environment(self, host_target):
5757
# we need to prefer the libraries we just built
5858
return {'DYLD_LIBRARY_PATH': os.path.join(
5959
_get_toolchain_path(host_target, self, self.args),
60-
'usr/lib/swift/macosx')}
60+
'usr', 'lib', 'swift', 'macosx')}
6161

6262
return None
6363

@@ -98,10 +98,9 @@ def get_dependencies(cls):
9898

9999

100100
def _get_toolchain_path(host_target, product, args):
101-
""" TODO check if we should prefer using product.install_toolchain_path
102-
this logic initially was inside run_build_script_helper
103-
and was factored out so it can be used in testing as well
104-
"""
101+
# TODO check if we should prefer using product.install_toolchain_path
102+
# this logic initially was inside run_build_script_helper
103+
# and was factored out so it can be used in testing as well
105104

106105
toolchain_path = swiftpm.SwiftPM.get_install_destdir(args,
107106
host_target,

0 commit comments

Comments
 (0)