Skip to content

Commit 0bfd572

Browse files
committed
[cxx-interop] Re-enable benchmarks
This adds an `import CxxStdlib` statement which fixes compilation. It should be redundant, but it works around a bug that got exposed by an change in explicit modules (rdar://128520766). This will bring back the performance numbers while the underlying issue is being investigated.
1 parent 71c81d5 commit 0bfd572

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

benchmark/CMakeLists.txt

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -209,11 +209,9 @@ set(SWIFT_BENCH_MODULES
209209
single-source/WordCount
210210
single-source/XorLoop
211211
cxx-source/CreateObjects
212-
# Disabled for rdar://128520766
213-
# cxx-source/CxxSetToCollection
212+
cxx-source/CxxSetToCollection
214213
cxx-source/CxxStringConversion
215-
# Disabled for rdar://128520766
216-
# cxx-source/CxxVectorSum
214+
cxx-source/CxxVectorSum
217215
# TODO: rdar://92120528
218216
# cxx-source/ReadAccessor
219217
)

benchmark/cxx-source/CxxSetToCollection.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ public let benchmarks = [BenchmarkInfo]()
2424

2525
import CxxStdlibPerformance
2626
import Cxx
27+
import CxxStdlib // FIXME(rdar://128520766): this import should be redundant
2728

2829
public let benchmarks = [
2930
BenchmarkInfo(

benchmark/cxx-source/CxxVectorSum.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ public let benchmarks = [BenchmarkInfo]()
2424

2525
import CxxStdlibPerformance
2626
import Cxx
27+
import CxxStdlib // FIXME(rdar://128520766): this import should be redundant
2728

2829
public let benchmarks = [
2930
BenchmarkInfo(

0 commit comments

Comments
 (0)