Skip to content

Commit 0c0f85d

Browse files
authored
Merge pull request #5921 from gottesmm/continuousintegration_update
[docs] Add an example of using github crossrepo PR references for cross repo PR testing.
2 parents 96837ba + 48b6255 commit 0c0f85d

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

docs/ContinuousIntegration.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,12 @@ https://github.com/apple/swift-package-manager/pull/632
142142
@swift-ci Please test macOS platform
143143
```
144144

145+
```
146+
apple/swift-lldb#48
147+
148+
@swift-ci Please test Linux platform
149+
```
150+
145151
1. Create a separate PR for each repository that needs to be changed. Each should reference the main Swift PR and create a reference to all of the others from the main PR.
146152

147153
2. Gate all commits on @swift-ci smoke test and merge. As stated above, it is important that *all* checkins perform PR testing since if breakage enters the tree PR testing becomes less effective. If you have done local testing (using build-toolchain) and have made appropriate changes to the other repositories then perform a smoke test and merge should be sufficient for correctness. This is not meant to check for correctness in your commits, but rather to be sure that no one landed changes in other repositories or in swift that cause your PR to no longer be correct. If you were unable to make workarounds to th eother repositories, this smoke test will break *after* Swift has built. Check the log to make sure that it is the expected failure for that platform/repository that coincides with the failure your PR is supposed to fix.

0 commit comments

Comments
 (0)