[MoveOnlyAddressChecker] Exclusivity handles DEs.

Switch to the areUsesWithinBoundary API which takes dead-ends into
account.

rdar://131960619

Author: nate-chandler

lib/SILOptimizer/Mandatory/MoveOnlyAddressCheckerTester.cpp

@@ -90,6 +90,7 @@ class MoveOnlyAddressCheckerTesterPass : public SILFunctionTransform {
     auto *dominanceAnalysis = getAnalysis<DominanceAnalysis>();
     DominanceInfo *domTree = dominanceAnalysis->get(fn);
     auto *poa = getAnalysis<PostOrderAnalysis>();
+    auto *deba = getAnalysis<DeadEndBlocksAnalysis>();
 
     DiagnosticEmitter diagnosticEmitter(fn);
     llvm::SmallSetVector<MarkUnresolvedNonCopyableValueInst *, 32>
@@ -108,8 +109,8 @@ class MoveOnlyAddressCheckerTesterPass : public SILFunctionTransform {
       LLVM_DEBUG(llvm::dbgs() << "No move introducers found?!\n");
     } else {
       borrowtodestructure::IntervalMapAllocator allocator;
-      MoveOnlyAddressChecker checker{getFunction(), diagnosticEmitter,
-                                     allocator, domTree, poa};
+      MoveOnlyAddressChecker checker{
+          getFunction(), diagnosticEmitter, allocator, domTree, deba, poa};
       madeChange = checker.completeLifetimes();
       madeChange |= checker.check(moveIntroducersToProcess);
     }

lib/SILOptimizer/Mandatory/MoveOnlyAddressCheckerUtils.cpp

@@ -1477,6 +1477,8 @@ struct MoveOnlyAddressCheckerPImpl {
   /// Information about destroys that we use when inserting destroys.
   ConsumeInfo consumes;
 
+  DeadEndBlocksAnalysis *deba;
+
   /// PostOrderAnalysis used by the BorrowToDestructureTransform.
   PostOrderAnalysis *poa;
 
@@ -1486,10 +1488,11 @@ struct MoveOnlyAddressCheckerPImpl {
   MoveOnlyAddressCheckerPImpl(
       SILFunction *fn, DiagnosticEmitter &diagnosticEmitter,
       DominanceInfo *domTree, PostOrderAnalysis *poa,
+      DeadEndBlocksAnalysis *deba,
       borrowtodestructure::IntervalMapAllocator &allocator)
       : fn(fn), deleter(), canonicalizer(fn, domTree, deleter),
         addressUseState(domTree), diagnosticEmitter(diagnosticEmitter),
-        poa(poa), allocator(allocator) {
+        deba(deba), poa(poa), allocator(allocator) {
     deleter.setCallbacks(std::move(
         InstModCallbacks().onDelete([&](SILInstruction *instToDelete) {
           if (auto *mvi =
@@ -2049,7 +2052,9 @@ struct GatherUsesVisitor : public TransitiveAddressWalker<GatherUsesVisitor> {
     liveness->initializeDef(bai);
     liveness->computeSimple();
     for (auto *consumingUse : li->getConsumingUses()) {
-      if (!liveness->isWithinBoundary(consumingUse->getUser())) {
+      if (!liveness->areUsesWithinBoundary(
+              {consumingUse},
+              moveChecker.deba->get(consumingUse->getFunction()))) {
         diagnosticEmitter.emitAddressExclusivityHazardDiagnostic(
             markedValue, consumingUse->getUser());
         emittedError = true;
@@ -3980,7 +3985,7 @@ bool MoveOnlyAddressChecker::check(
         &moveIntroducersToProcess) {
   assert(moveIntroducersToProcess.size() &&
          "Must have checks to process to call this function");
-  MoveOnlyAddressCheckerPImpl pimpl(fn, diagnosticEmitter, domTree, poa,
+  MoveOnlyAddressCheckerPImpl pimpl(fn, diagnosticEmitter, domTree, poa, deba,
                                     allocator);
 
 #ifndef NDEBUG

lib/SILOptimizer/Mandatory/MoveOnlyAddressCheckerUtils.h

@@ -18,6 +18,7 @@
 namespace swift {
 
 class PostOrderAnalysis;
+class DeadEndBlocksAnalysis;
 
 namespace siloptimizer {
 
@@ -38,6 +39,7 @@ struct MoveOnlyAddressChecker {
   DiagnosticEmitter &diagnosticEmitter;
   borrowtodestructure::IntervalMapAllocator &allocator;
   DominanceInfo *domTree;
+  DeadEndBlocksAnalysis *deba;
   PostOrderAnalysis *poa;
 
   /// \returns true if we changed the IR. To see if we emitted a diagnostic, use

lib/SILOptimizer/Mandatory/MoveOnlyChecker.cpp

@@ -78,14 +78,14 @@ struct MoveOnlyChecker {
   DiagnosticEmitter diagnosticEmitter;
   SILFunction *fn;
   DominanceInfo *domTree;
+  DeadEndBlocksAnalysis *deba;
   PostOrderAnalysis *poa;
   bool madeChange = false;
   borrowtodestructure::IntervalMapAllocator allocator;
 
   MoveOnlyChecker(SILFunction *fn, DominanceInfo *domTree,
-                  PostOrderAnalysis *poa)
-      : diagnosticEmitter(fn), fn(fn), domTree(domTree), poa(poa) {
-  }
+                  DeadEndBlocksAnalysis *deba, PostOrderAnalysis *poa)
+      : diagnosticEmitter(fn), fn(fn), domTree(domTree), deba(deba), poa(poa) {}
 
   void checkObjects();
   void completeObjectLifetimes(ArrayRef<MarkUnresolvedNonCopyableValueInst *>);
@@ -203,8 +203,8 @@ void MoveOnlyChecker::checkAddresses() {
     return;
   }
 
-  MoveOnlyAddressChecker checker{fn, diagnosticEmitter, allocator, domTree,
-                                 poa};
+  MoveOnlyAddressChecker checker{
+      fn, diagnosticEmitter, allocator, domTree, deba, poa};
   madeChange |= checker.completeLifetimes();
   madeChange |= checker.check(moveIntroducersToProcess);
 }
@@ -256,9 +256,9 @@ class MoveOnlyCheckerPass : public SILFunctionTransform {
     LLVM_DEBUG(llvm::dbgs()
                << "===> MoveOnly Checker. Visiting: " << fn->getName() << '\n');
 
-    MoveOnlyChecker checker(
-        fn, getAnalysis<DominanceAnalysis>()->get(fn),
-        getAnalysis<PostOrderAnalysis>());
+    MoveOnlyChecker checker(fn, getAnalysis<DominanceAnalysis>()->get(fn),
+                            getAnalysis<DeadEndBlocksAnalysis>(),
+                            getAnalysis<PostOrderAnalysis>());
 
     checker.checkObjects();
     checker.checkAddresses();

test/SILOptimizer/moveonly_addresschecker.swift

@@ -35,3 +35,14 @@ func testAssertLikeUseDifferentBits() {
         }
     }
 }
+
+// issue #75312
+struct S
+{
+    @usableFromInline
+    init(utf8:consuming [UInt8])
+    {
+        utf8.withUnsafeBufferPointer { _ in }
+        fatalError()
+    }
+}