Merge pull request #30156 from eeckstein/global-opt-fix

GlobalOpt: handle access markers correctly.

Author: eeckstein

lib/SILOptimizer/IPO/GlobalOpt.cpp

@@ -730,6 +730,7 @@ bool SILGlobalOpt::tryRemoveUnusedGlobal(SILGlobalVariable *global) {
 static bool isPotentialStore(SILInstruction *inst) {
   switch (inst->getKind()) {
     case SILInstructionKind::LoadInst:
+    case SILInstructionKind::EndAccessInst:
       return false;
     case SILInstructionKind::StructElementAddrInst:
     case SILInstructionKind::TupleElementAddrInst:

test/SILOptimizer/globalopt_global_propagation.swift

@@ -1,7 +1,7 @@
-// RUN: %target-swift-frontend -O -emit-sil -enforce-exclusivity=unchecked  %s | %FileCheck %s
-// RUN: %target-swift-frontend -O -wmo -emit-sil -enforce-exclusivity=unchecked  %s | %FileCheck -check-prefix=CHECK-WMO %s
-// RUN: %target-swift-frontend -parse-as-library -O -emit-sil -enforce-exclusivity=unchecked  %s | %FileCheck %s
-// RUN: %target-swift-frontend -parse-as-library -O -wmo -emit-sil -enforce-exclusivity=unchecked  %s | %FileCheck -check-prefix=CHECK-WMO %s
+// RUN: %target-swift-frontend -O -emit-sil %s | %FileCheck %s
+// RUN: %target-swift-frontend -O -wmo -emit-sil %s | %FileCheck -check-prefix=CHECK-WMO %s
+// RUN: %target-swift-frontend -parse-as-library -O -emit-sil %s | %FileCheck %s
+// RUN: %target-swift-frontend -parse-as-library -O -wmo -emit-sil %s | %FileCheck -check-prefix=CHECK-WMO %s
 
 // Check that values of internal and private global variables, which are provably assigned only 
 // once, are propagated into their uses and enable further optimizations like constant
@@ -93,6 +93,7 @@ public func test_internal_global_var_int() -> Int {
 // CHECK-WMO-LABEL: sil [noinline] @$s28globalopt_global_propagation012test_public_B11_var_doubleSdyF
 // CHECK-WMO: bb0:
 // CHECK-WMO-NEXT: global_addr
+// CHECK-WMO-NEXT: begin_access [read] [dynamic]
 // CHECK-WMO-NEXT: struct_element_addr
 // CHECK-WMO-NEXT: load
 @inline(never)
@@ -105,6 +106,7 @@ public func test_public_global_var_double() -> Double {
 // CHECK-LABEL: sil [noinline] @$s28globalopt_global_propagation012test_public_B8_var_intSiyF
 // CHECK: bb0: 
 // CHECK-NEXT: global_addr
+// CHECK-NEXT: begin_access [read] [dynamic]
 // CHECK-NEXT: struct_element_addr
 // CHECK-NEXT: load
 @inline(never)