Skip to content

Commit 0e01344

Browse files
committed
Add explanatory comments around freestanding test configuration
Tackles feedback of the review of #40202
1 parent 403ccd4 commit 0e01344

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

test/lit.cfg

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -967,6 +967,8 @@ if run_vendor == 'apple':
967967
if not config.swift_freestanding_is_darwin:
968968
swift_execution_tests_extra_flags += ' -Xlinker -dead_strip'
969969

970+
# TODO: consider making the addition of these flags dependent on the CMake
971+
# setting for hermetic seal at link
970972
if not config.swift_freestanding_is_darwin:
971973
swift_execution_tests_extra_flags += ' -experimental-hermetic-seal-at-link -lto=llvm-full'
972974

@@ -980,6 +982,8 @@ if run_vendor == 'apple':
980982
symlink_if_not_exists("clang", "clang")
981983
symlink_if_not_exists("shims", "shims")
982984
symlink_if_not_exists("freestanding", "macosx")
985+
# This is needed to allow compiling against Dispatch
986+
# TODO: consider making this dependent on swift_enable_dispatch
983987
if config.swift_freestanding_is_darwin:
984988
symlink_if_not_exists("apinotes", "apinotes")
985989
config.resource_dir_opt = "-resource-dir %s" % new_resource_dir

0 commit comments

Comments
 (0)