[NFC] MOWTE: Deduplicated code.

Replaced copy-pasted code with a twice-invoked closure.  In preparation
to add a third invocation.

Author: nate-chandler

lib/SILOptimizer/Mandatory/MoveOnlyWrappedTypeEliminator.cpp

@@ -298,47 +298,51 @@ bool SILMoveOnlyWrappedTypeEliminator::process() {
   llvm::SmallSetVector<SILArgument *, 8> touchedArgs;
   llvm::SmallSetVector<SILInstruction *, 8> touchedInsts;
 
+  auto recordValue = [&touchedInsts, fn = fn,
+                      trivialOnly = trivialOnly](SILValue value) -> bool {
+    if (!value->getType().isMoveOnlyWrapped() &&
+        !value->getType().isBoxedMoveOnlyWrappedType(fn))
+      return false;
+
+    // If we are looking at trivial only, skip non-trivial function args.
+    if (trivialOnly && !isMoveOnlyWrappedTrivial(value))
+      return false;
+
+    value->unsafelyEliminateMoveOnlyWrapper(fn);
+    for (auto *use : value->getNonTypeDependentUses())
+      touchedInsts.insert(use->getUser());
+    return true;
+  };
+
   for (auto &bb : *fn) {
     for (auto *arg : bb.getArguments()) {
-      if (!arg->getType().isMoveOnlyWrapped() &&
-          !arg->getType().isBoxedMoveOnlyWrappedType(fn))
-        continue;
-
-      // If we are looking at trivial only, skip non-trivial function args.
-      if (trivialOnly &&
-          !arg->getType().removingMoveOnlyWrapper().isTrivial(*fn))
+      bool relevant = recordValue(arg);
+      if (!relevant)
         continue;
 
-      arg->unsafelyEliminateMoveOnlyWrapper(fn);
-
       // If our new type is trivial, convert the arguments ownership to
       // None. Otherwise, preserve the ownership kind of the argument.
       if (arg->getType().isTrivial(*fn))
         arg->setOwnershipKind(OwnershipKind::None);
       touchedArgs.insert(arg);
-      for (auto *use : arg->getNonTypeDependentUses())
-        touchedInsts.insert(use->getUser());
+
+      madeChange = true;
     }
 
     for (auto &ii : bb) {
-      for (SILValue v : ii.getResults()) {
-        if (!v->getType().isMoveOnlyWrapped() &&
-            !v->getType().isBoxedMoveOnlyWrappedType(fn))
-          continue;
-
-        if (trivialOnly &&
-            !isMoveOnlyWrappedTrivial(v))
+      bool touched = false;
+      for (SILValue value : ii.getResults()) {
+        bool relevant = recordValue(value);
+        if (!relevant)
           continue;
 
-        v->unsafelyEliminateMoveOnlyWrapper(fn);
-        touchedInsts.insert(&ii);
-
-        // Add all users as well. This ensures we visit things like
-        // destroy_value and end_borrow.
-        for (auto *use : v->getNonTypeDependentUses())
-          touchedInsts.insert(use->getUser());
-        madeChange = true;
+        touched = true;
       }
+      if (!touched)
+        continue;
+      touchedInsts.insert(&ii);
+
+      madeChange = true;
     }
   }