Skip to content

Commit 101f0b0

Browse files
committed
---
yaml --- r: 347758 b: refs/heads/master c: c974145 h: refs/heads/master
1 parent f707c21 commit 101f0b0

File tree

4 files changed

+1
-20
lines changed

4 files changed

+1
-20
lines changed

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
refs/heads/master: 39abc221993cfd400ca0076fdc28dcd940d74db7
2+
refs/heads/master: c974145c70501678207c17807cebadaafdfe3262
33
refs/heads/master-next: 203b3026584ecad859eb328b2e12490099409cd5
44
refs/tags/osx-passed: b6b74147ef8a386f532cf9357a1bde006e552c54
55
refs/tags/swift-2.2-SNAPSHOT-2015-12-01-a: 6bb18e013c2284f2b45f5f84f2df2887dc0f7dea

trunk/lib/Sema/TypeCheckDecl.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4307,9 +4307,6 @@ void TypeChecker::validateDeclForNameLookup(ValueDecl *D) {
43074307
return;
43084308
proto->computeType();
43094309

4310-
// Compute the requirement signature later to avoid circularity.
4311-
DelayedRequirementSignatures.insert(proto);
4312-
43134310
// FIXME: IRGen likes to emit @objc protocol descriptors even if the
43144311
// protocol comes from a different module or translation unit.
43154312
//

trunk/lib/Sema/TypeChecker.cpp

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -341,16 +341,6 @@ static void typeCheckFunctionsAndExternalDecls(SourceFile &SF, TypeChecker &TC)
341341
llvm_unreachable("Unhandled external definition kind");
342342
}
343343

344-
// Complete any protocol requirement signatures that were delayed
345-
// because the protocol was validated via validateDeclForNameLookup().
346-
while (!TC.DelayedRequirementSignatures.empty()) {
347-
auto decl = TC.DelayedRequirementSignatures.pop_back_val();
348-
if (decl->isInvalid() || TC.Context.hadError())
349-
continue;
350-
351-
TC.validateDecl(decl);
352-
}
353-
354344
// Validate any referenced declarations for SIL's purposes.
355345
// Note: if we ever start putting extension members in vtables, we'll need
356346
// to validate those members too.
@@ -398,7 +388,6 @@ static void typeCheckFunctionsAndExternalDecls(SourceFile &SF, TypeChecker &TC)
398388
currentSynthesizedDecl < SF.SynthesizedDecls.size() ||
399389
TC.NextDeclToFinalize < TC.DeclsToFinalize.size() ||
400390
!TC.ConformanceContexts.empty() ||
401-
!TC.DelayedRequirementSignatures.empty() ||
402391
!TC.UsedConformances.empty() ||
403392
!TC.PartiallyCheckedConformances.empty());
404393

trunk/lib/Sema/TypeChecker.h

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -569,11 +569,6 @@ class TypeChecker final : public LazyResolver {
569569
/// from the \c DeclsToFinalize set.
570570
unsigned NextDeclToFinalize = 0;
571571

572-
/// The list of protocols that need their requirement signatures computed,
573-
/// because they were first validated by validateDeclForNameLookup(),
574-
/// which skips this step.
575-
llvm::SetVector<ProtocolDecl *> DelayedRequirementSignatures;
576-
577572
/// The list of types whose circularity checks were delayed.
578573
SmallVector<NominalTypeDecl*, 8> DelayedCircularityChecks;
579574

0 commit comments

Comments
 (0)