TODO: missing cases

atrick · atrick · commit 117d40ba7fcd · 2024-01-06T17:41:45.000-08:00
diff --git a/SwiftCompilerSources/Sources/Optimizer/Utilities/OwnershipLiveness.swift b/SwiftCompilerSources/Sources/Optimizer/Utilities/OwnershipLiveness.swift
@@ -358,6 +358,7 @@ extension InteriorUseVisitor: AddressDefUseWalker {
     if address.value.type.objectType.isTrivial(in: function) {
       return .continueWalk
     }
+    //!!! handle BeginAccess
     switch address.instruction {
     case let load as LoadBorrowInst:
       return visitUsesOfInner(value: load)

Original file line number	Diff line number	Diff line change
`@@ -358,6 +358,7 @@ extension InteriorUseVisitor: AddressDefUseWalker {`
`358`	`358`	`if address.value.type.objectType.isTrivial(in: function) {`
`359`	`359`	`return .continueWalk`
`360`	`360`	`}`
	`361`	`+ //!!! handle BeginAccess`
`361`	`362`	`switch address.instruction {`
`362`	`363`	`case let load as LoadBorrowInst:`
`363`	`364`	`return visitUsesOfInner(value: load)`