Skip to content

Commit 1219d4b

Browse files
committed
[Distributed] Remove redundant isa check in getting SR
1 parent 9af39f9 commit 1219d4b

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

lib/AST/DistributedDecl.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ Type swift::getSerializationRequirementTypesForMember(
110110
auto SerReqAssocType = DA->getAssociatedType(C.Id_SerializationRequirement)
111111
->getDeclaredInterfaceType();
112112

113-
if (DC->getSelfProtocolDecl() || isa<ExtensionDecl>(DC)) {
113+
if (DC->getSelfProtocolDecl()) {
114114
GenericSignature signature;
115115
if (auto *genericContext = member->getAsGenericContext()) {
116116
signature = genericContext->getGenericSignature();

test/Distributed/distributed_protocols_distributed_func_serialization_requirements.swift

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,13 @@ extension NoSerializationRequirementYet
8888
}
8989
}
9090

91+
extension ProtocolWithChecksSeqReqDA {
92+
// expected-error@+1{{result type 'NotCodable' of distributed instance method 'test4' does not conform to serialization requirement 'Codable'}}
93+
distributed func test4() -> NotCodable {
94+
.init()
95+
}
96+
}
97+
9198
// FIXME(distributed): remove the -verify-ignore-unknown
9299
// <unknown>:0: error: unexpected error produced: instance method 'recordReturnType' requires that 'NotCodable' conform to 'Decodable'
93100
// <unknown>:0: error: unexpected error produced: instance method 'recordReturnType' requires that 'NotCodable' conform to 'Encodable'

0 commit comments

Comments
 (0)