Skip to content

Commit 127b2ab

Browse files
aschwaighoferaschwaighofer
committed
Remove the remaining swift_test_mode_optimize_none_with_implicit_dynamic
It is expected that under enable-private-import internal/private symbols become public. So that symbol-diffing would fail. Disable symbol diffing under that test mode. rdar://51304243
1 parent d878aed commit 127b2ab

14 files changed

+1
-26
lines changed

‎test/lit.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1394,7 +1394,7 @@ config.target_resilience_test = (
13941394

13951395
# FIXME: Get symbol diffing working with binutils nm as well. The flags are slightly
13961396
# different.
1397-
if platform.system() != 'Darwin':
1397+
if platform.system() != 'Darwin' or swift_test_mode == 'optimize_none_with_implicit_dynamic':
13981398
config.target_resilience_test = ('%s --no-symbol-diff' %
13991399
config.target_resilience_test)
14001400

‎validation-test/Evolution/test_bitwise_takable.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
// RUN: %target-resilience-test
22
// REQUIRES: executable_test
33

4-
// UNSUPPORTED: swift_test_mode_optimize_none_with_implicit_dynamic
5-
64
import StdlibUnittest
75
import bitwise_takable
86

‎validation-test/Evolution/test_class_change_size.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
// RUN: %target-resilience-test
22
// REQUIRES: executable_test
33

4-
// UNSUPPORTED: swift_test_mode_optimize_none_with_implicit_dynamic
5-
64
import StdlibUnittest
75
import class_change_size
86

‎validation-test/Evolution/test_class_insert_superclass.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
// RUN: %target-resilience-test
22
// REQUIRES: executable_test
33

4-
// UNSUPPORTED: swift_test_mode_optimize_none_with_implicit_dynamic
5-
64
import StdlibUnittest
75
import class_insert_superclass
86

‎validation-test/Evolution/test_class_remove_property.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
// RUN: %target-resilience-test
22
// REQUIRES: executable_test
33

4-
// UNSUPPORTED: swift_test_mode_optimize_none_with_implicit_dynamic
5-
64
import StdlibUnittest
75
import class_remove_property
86

‎validation-test/Evolution/test_enum_change_size.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
// RUN: %target-resilience-test
22
// REQUIRES: executable_test
33

4-
// UNSUPPORTED: swift_test_mode_optimize_none_with_implicit_dynamic
5-
64
import StdlibUnittest
75
import enum_change_size
86

‎validation-test/Evolution/test_global_change_size.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
// RUN: %target-resilience-test
22
// REQUIRES: executable_test
33

4-
// UNSUPPORTED: swift_test_mode_optimize_none_with_implicit_dynamic
5-
64
import StdlibUnittest
75
import global_change_size
86

‎validation-test/Evolution/test_struct_add_property.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
// RUN: %target-resilience-test
22
// REQUIRES: executable_test
33

4-
// UNSUPPORTED: swift_test_mode_optimize_none_with_implicit_dynamic
5-
64
import StdlibUnittest
75
import struct_add_property
86

‎validation-test/Evolution/test_struct_change_size.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
// RUN: %target-resilience-test
22
// REQUIRES: executable_test
33

4-
// UNSUPPORTED: swift_test_mode_optimize_none_with_implicit_dynamic
5-
64
import StdlibUnittest
75
import struct_change_size
86

‎validation-test/Evolution/test_struct_change_stored_to_computed.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
// RUN: %target-resilience-test
22
// REQUIRES: executable_test
33

4-
// UNSUPPORTED: swift_test_mode_optimize_none_with_implicit_dynamic
5-
64
import StdlibUnittest
75
import struct_change_stored_to_computed
86

‎validation-test/Evolution/test_struct_change_stored_to_computed_static.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
// RUN: %target-resilience-test
22
// REQUIRES: executable_test
33

4-
// UNSUPPORTED: swift_test_mode_optimize_none_with_implicit_dynamic
5-
64
import StdlibUnittest
75
import struct_change_stored_to_computed_static
86

‎validation-test/Evolution/test_struct_fixed_layout_remove_conformance.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
// RUN: %target-resilience-test
22
// REQUIRES: executable_test
33

4-
// UNSUPPORTED: swift_test_mode_optimize_none_with_implicit_dynamic
5-
64
import StdlibUnittest
75
import struct_fixed_layout_remove_conformance
86

‎validation-test/Evolution/test_struct_remove_property.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
// RUN: %target-resilience-test
22
// REQUIRES: executable_test
33

4-
// UNSUPPORTED: swift_test_mode_optimize_none_with_implicit_dynamic
54

65
import StdlibUnittest
76
import struct_remove_property

‎validation-test/Evolution/test_struct_resilient_remove_conformance.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
// RUN: %target-resilience-test
22
// REQUIRES: executable_test
33

4-
// UNSUPPORTED: swift_test_mode_optimize_none_with_implicit_dynamic
5-
64
import StdlibUnittest
75
import struct_resilient_remove_conformance
86

0 commit comments

Comments
 (0)