Stop pessimizing print performance for no reason.

lattner · lattner · commit 1287d62f8fad · 2018-01-22T19:56:37.000-08:00
As pointed out in Ole Begeman's blog: https://oleb.net/blog/2016/09/playground-print-hook/ The playground print hook is being initialized a a non-null noop hook, which causes the fast paths in the print functions to be unused, and forcing the creation of a tee stream for things that have nothing to do with playgrounds. It is sad that no one noticed this...
diff --git a/stdlib/public/core/OutputStream.swift b/stdlib/public/core/OutputStream.swift
@@ -621,7 +621,7 @@ extension Unicode.Scalar : TextOutputStreamable {
 }
 
 /// A hook for playgrounds to print through.
-public var _playgroundPrintHook : ((String) -> Void)? = {_ in () }
+public var _playgroundPrintHook : ((String) -> Void)? = nil
 
 @_fixed_layout // FIXME(sil-serialize-all)
 @_versioned // FIXME(sil-serialize-all)

Original file line number	Diff line number	Diff line change
`@@ -621,7 +621,7 @@ extension Unicode.Scalar : TextOutputStreamable {`
`621`	`621`	`}`
`622`	`622`
`623`	`623`	`/// A hook for playgrounds to print through.`
`624`		`-public var _playgroundPrintHook : ((String) -> Void)? = {_ in () }`
	`624`	`+public var _playgroundPrintHook : ((String) -> Void)? = nil`
`625`	`625`
`626`	`626`	`@_fixed_layout // FIXME(sil-serialize-all)`
`627`	`627`	`@_versioned // FIXME(sil-serialize-all)`