Skip to content

Commit 1489eba

Browse files
committed
Clean up macro implementation warnings
1 parent 7d1bd3e commit 1489eba

File tree

2 files changed

+11
-9
lines changed

2 files changed

+11
-9
lines changed

lib/Macros/Sources/ObservationMacros/Extensions.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ extension VariableDeclSyntax {
5858
guard let decl = accessor.as(AccessorDeclSyntax.self) else {
5959
return nil
6060
}
61-
if predicate(decl.accessorKind.tokenKind) {
61+
if predicate(decl.accessorSpecifier.tokenKind) {
6262
return decl
6363
} else {
6464
return nil
@@ -85,7 +85,7 @@ extension VariableDeclSyntax {
8585

8686

8787
var isImmutable: Bool {
88-
return bindingKeyword.tokenKind == .keyword(.let)
88+
return bindingSpecifier.tokenKind == .keyword(.let)
8989
}
9090

9191
func isEquivalent(to other: VariableDeclSyntax) -> Bool {
@@ -198,9 +198,9 @@ extension FunctionDeclSyntax {
198198
var signatureStandin: SignatureStandin {
199199
var parameters = [String]()
200200
for parameter in signature.input.parameterList {
201-
parameters.append(parameter.firstName.text + ":" + (parameter.type.genericSubstitution(genericParameterClause?.genericParameterList) ?? "" ))
201+
parameters.append(parameter.firstName.text + ":" + (parameter.type.genericSubstitution(genericParameterClause?.parameters) ?? "" ))
202202
}
203-
let returnType = signature.output?.returnType.genericSubstitution(genericParameterClause?.genericParameterList) ?? "Void"
203+
let returnType = signature.output?.returnType.genericSubstitution(genericParameterClause?.parameters) ?? "Void"
204204
return SignatureStandin(isInstance: isInstance, identifier: identifier.text, parameters: parameters, returnType: returnType)
205205
}
206206

lib/Macros/Sources/ObservationMacros/ObservableMacro.swift

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ public struct ObservableMacro {
7171
static var ignoredAttribute: AttributeSyntax {
7272
AttributeSyntax(
7373
leadingTrivia: .space,
74-
atSignToken: .atSignToken(),
74+
atSign: .atSignToken(),
7575
attributeName: SimpleTypeIdentifierSyntax(name: .identifier(ignoredMacroName)),
7676
trailingTrivia: .space
7777
)
@@ -173,12 +173,14 @@ extension PatternBindingListSyntax {
173173
}
174174

175175
extension VariableDeclSyntax {
176-
func privatePrefixed(_ prefix: String, addingAttribute attribute: AttributeSyntax) -> VariableDeclSyntax {
177-
VariableDeclSyntax(
176+
func privatePrefixed(_ prefix: String, addingAttribute attribute: AttributeSyntax) -> VariableDeclSyntax {
177+
let newAttributes = AttributeListSyntax(
178+
(attributes.map(Array.init) ?? []) + [.attribute(attribute)])
179+
return VariableDeclSyntax(
178180
leadingTrivia: leadingTrivia,
179-
attributes: attributes?.appending(.attribute(attribute)) ?? [.attribute(attribute)],
181+
attributes: newAttributes,
180182
modifiers: modifiers?.privatePrefixed(prefix) ?? ModifierListSyntax(keyword: .private),
181-
bindingKeyword: TokenSyntax(bindingKeyword.tokenKind, leadingTrivia: .space, trailingTrivia: .space, presence: .present),
183+
bindingSpecifier: TokenSyntax(bindingSpecifier.tokenKind, leadingTrivia: .space, trailingTrivia: .space, presence: .present),
182184
bindings: bindings.privatePrefixed(prefix),
183185
trailingTrivia: trailingTrivia
184186
)

0 commit comments

Comments
 (0)