reword diagnostics for partial consume of fields

Author: kavon

include/swift/AST/DiagnosticsSIL.def

@@ -773,12 +773,9 @@ ERROR(sil_moveonlychecker_notconsumable_but_assignable_was_consumed, none,
       "cannot consume noncopyable stored property '%0' %select{of a class|that is global}1",
       (StringRef, bool))
 
-ERROR(sil_moveonlychecker_cannot_destructure_deinit_nominal_type_self, none,
-      "Cannot partially consume '%0' since it has a user defined deinit",
+ERROR(sil_moveonlychecker_cannot_destructure_has_deinit, none,
+      "cannot partially consume '%0' since it has a user defined deinit",
       (StringRef))
-ERROR(sil_moveonlychecker_cannot_destructure_deinit_nominal_type_field, none,
-      "Cannot partially consume '%0' since it contains field '%1.%2' whose type %3 has a user defined deinit",
-      (StringRef, StringRef, StringRef, DeclBaseName))
 
 NOTE(sil_moveonlychecker_partial_consume_here, none,
      "partial consume here", ())

lib/SILOptimizer/Mandatory/MoveOnlyDiagnostics.cpp

@@ -683,25 +683,21 @@ void DiagnosticEmitter::emitCannotDestructureDeinitNominalError(
     MarkMustCheckInst *markedValue, StringRef pathString,
     NominalTypeDecl *deinitedNominal, SILInstruction *consumingUser) {
   auto &astContext = fn->getASTContext();
+
   SmallString<64> varName;
   getVariableNameForValue(markedValue, varName);
 
+  if (!pathString.empty())
+    varName.append(pathString);
+
+  diagnose(
+      astContext, consumingUser,
+      diag::sil_moveonlychecker_cannot_destructure_has_deinit,
+      varName);
   registerDiagnosticEmitted(markedValue);
 
-  if (pathString.empty()) {
-    diagnose(
-        astContext, markedValue,
-        diag::sil_moveonlychecker_cannot_destructure_deinit_nominal_type_self,
-        varName);
-  } else {
-    diagnose(
-        astContext, markedValue,
-        diag::sil_moveonlychecker_cannot_destructure_deinit_nominal_type_field,
-        varName, varName, pathString.drop_front(),
-        deinitedNominal->getBaseName());
-  }
-  diagnose(astContext, consumingUser,
-           diag::sil_moveonlychecker_consuming_use_here);
-  astContext.Diags.diagnose(deinitedNominal->getValueTypeDestructor(),
-                            diag::sil_moveonlychecker_deinit_here);
+  // point to the deinit if we know where it is.
+  if (auto deinitLoc =
+      deinitedNominal->getValueTypeDestructor()->getLoc(/*SerializedOK=*/false))
+    astContext.Diags.diagnose(deinitLoc, diag::sil_moveonlychecker_deinit_here);
 }

test/SILOptimizer/moveonly_addresschecker_destructure_through_deinit_diagnostics.swift

@@ -58,17 +58,7 @@ struct DeinitStruct {
   var fourth: (MoveOnlyKlass, MoveOnlyKlass)
   var fifth: MoveOnlyKlass
 
-  deinit {}
-  // expected-note @-1 {{deinit declared here}}
-  // expected-note @-2 {{deinit declared here}}
-  // expected-note @-3 {{deinit declared here}}
-  // expected-note @-4 {{deinit declared here}}
-  // expected-note @-5 {{deinit declared here}}
-  // expected-note @-6 {{deinit declared here}}
-  // expected-note @-7 {{deinit declared here}}
-  // expected-note @-8 {{deinit declared here}}
-  // expected-note @-9 {{deinit declared here}}
-  // expected-note @-10 {{deinit declared here}}
+  deinit {} // expected-note 10{{deinit declared here}}
 }
 
 func testConsumeCopyable(_ x: consuming DeinitStruct) {
@@ -78,24 +68,24 @@ func testConsumeCopyable(_ x: consuming DeinitStruct) {
 }
 
 func testConsumeNonCopyable1(_ x: consuming DeinitStruct) {
-    // expected-error @-1 {{Cannot partially consume 'x' since it has a user defined deinit}}
-    consume(x.third.rhs) // expected-note {{consuming use here}}
+    // expected-error @+1 {{cannot partially consume 'x' since it has a user defined deinit}}
+    consume(x.third.rhs)
 }
 
 func testConsumeNonCopyable2(_ x: consuming DeinitStruct) {
-    // expected-error @-1 {{Cannot partially consume 'x' since it has a user defined deinit}}
-    consume(x.fourth.0) // expected-note {{consuming use here}}
+    // expected-error @+1 {{cannot partially consume 'x' since it has a user defined deinit}}
+    consume(x.fourth.0)
 }
 
 func testConsumeNonCopyable3(_ x: consuming DeinitStruct) {
-    // expected-error @-1 {{Cannot partially consume 'x' since it has a user defined deinit}}
-    consume(x.fourth.1) // expected-note {{consuming use here}}
+    // expected-error @+1 {{cannot partially consume 'x' since it has a user defined deinit}}
+    consume(x.fourth.1)
 }
 
 
 func testConsumeNonCopyable4(_ x: consuming DeinitStruct) {
-    // expected-error @-1 {{Cannot partially consume 'x' since it has a user defined deinit}}
-    consume(x.fifth) // expected-note {{consuming use here}}
+    // expected-error @+1 {{cannot partially consume 'x' since it has a user defined deinit}}
+    consume(x.fifth)
 }
 
 /////////////////
@@ -123,33 +113,33 @@ func testStructContainDeinitStructConsumeCopyable1(_ x: consuming StructContainD
 }
 
 
-func testStructContainStructContainDeinitStructConsumeNonCopyable1(_ x: consuming StructContainDeinitStruct) {
-    // expected-error @-1 {{Cannot partially consume 'x' since it contains field 'x.first' whose type 'DeinitStruct' has a user defined deinit}}
-    consume(x.first.third.rhs) // expected-note {{consuming use here}}
+func testStructContainStructContainDeinitStructConsumeNonCopyable1(_ xyz: consuming StructContainDeinitStruct) {
+    // expected-error @+1 {{cannot partially consume 'xyz.first' since it has a user defined deinit}}
+    consume(xyz.first.third.rhs)
 }
 
 func testStructContainStructContainDeinitStructConsumeNonCopyable1a(_ x: consuming StructContainDeinitStruct) {
-    // expected-error @-1 {{Cannot partially consume 'x' since it contains field 'x.second.0' whose type 'DeinitStruct' has a user defined deinit}}
-    consume(x.second.0.third.rhs) // expected-note {{consuming use here}}
+    // expected-error @+1 {{cannot partially consume 'x.second.0' since it has a user defined deinit}}
+    consume(x.second.0.third.rhs)
 }
 
 func testStructContainStructContainDeinitStructConsumeNonCopyable2(_ x: consuming StructContainDeinitStruct) {
-    // expected-error @-1 {{Cannot partially consume 'x' since it contains field 'x.first' whose type 'DeinitStruct' has a user defined deinit}}
-    consume(x.first.fourth.0) // expected-note {{consuming use here}}
+    // expected-error @+1 {{cannot partially consume 'x.first' since it has a user defined deinit}}
+    consume(x.first.fourth.0)
 }
 
 func testStructContainStructContainDeinitStructConsumeNonCopyable2a(_ x: consuming StructContainDeinitStruct) {
-    // expected-error @-1 {{Cannot partially consume 'x' since it contains field 'x.second.1' whose type 'DeinitStruct' has a user defined deinit}}
-    consume(x.second.1.fourth.0) // expected-note {{consuming use here}}
+    // expected-error @+1 {{cannot partially consume 'x.second.1' since it has a user defined deinit}}
+    consume(x.second.1.fourth.0)
 }
 
 func testStructContainStructContainDeinitStructConsumeNonCopyable3(_ x: consuming StructContainDeinitStruct) {
-    // expected-error @-1 {{Cannot partially consume 'x' since it contains field 'x.first' whose type 'DeinitStruct' has a user defined deinit}}
-    consume(x.first.fourth.1) // expected-note {{consuming use here}}
+    // expected-error @+1 {{cannot partially consume 'x.first' since it has a user defined deinit}}
+    consume(x.first.fourth.1)
 }
 
 
 func testStructContainStructContainDeinitStructConsumeNonCopyable4(_ x: consuming StructContainDeinitStruct) {
-    // expected-error @-1 {{Cannot partially consume 'x' since it contains field 'x.first' whose type 'DeinitStruct' has a user defined deinit}}
-    consume(x.first.fifth) // expected-note {{consuming use here}}
+    // expected-error @+1 {{cannot partially consume 'x.first' since it has a user defined deinit}}
+    consume(x.first.fifth)
 }