Skip to content

Commit 1715021

Browse files
committed
[TypeChecker] NFC: Clarify flaky diagnostic XFAIL
Instead of XFAILing whole `test/Constraints/operator.swift` let's adjust diagnostic responsible for flakiness.
1 parent 4ef82a8 commit 1715021

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

test/Constraints/operator.swift

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// REQUIRES: rdar64844584
21
// RUN: %target-typecheck-verify-swift
32

43
// Test constraint simplification of chains of binary operators.
@@ -217,11 +216,13 @@ func rdar46459603() {
217216
let e = E.foo(value: "String")
218217
var arr = ["key": e]
219218

219+
// FIXME(rdar://problem/64844584) - on iOS simulator this diagnostic is flaky,
220+
// either `referencing operator function '==' on 'Equatable'` or `operator function '==' requires`
220221
_ = arr.values == [e]
221-
// expected-error@-1 {{referencing operator function '==' on 'Equatable' requires that 'Dictionary<String, E>.Values' conform to 'Equatable'}}
222+
// expected-error@-1 {{requires that 'Dictionary<String, E>.Values' conform to 'Equatable'}}
222223
// expected-error@-2 {{cannot convert value of type '[E]' to expected argument type 'Dictionary<String, E>.Values'}}
223224
_ = [arr.values] == [[e]]
224-
// expected-error@-1 {{referencing operator function '==' on 'Array' requires that 'Dictionary<String, E>.Values' conform to 'Equatable'}}
225+
// expected-error@-1 {{requires that 'Dictionary<String, E>.Values' conform to 'Equatable'}}
225226
// expected-error@-2 {{cannot convert value of type '[E]' to expected element type 'Dictionary<String, E>.Values'}}
226227
}
227228

0 commit comments

Comments
 (0)