Merge pull request #37487 from gottesmm/release/5.4-77325585

[5.4][sil][debug-info] Turn off a few asserts just on 5.4 to eliminate some crashes in user code.

Author: gottesmm

lib/SIL/Verifier/SILVerifier.cpp

@@ -1214,6 +1214,16 @@ class SILVerifier : public SILVerifierBase<SILVerifier> {
       }
     }
 
+// Disable these checks just on 5.4 when compiler asserts are enabled.
+//
+// These just verify some things about debug info that shouldn't stop a program
+// from not-compiling. When optimizing in certain cases, we found that we were
+// hitting these on linux platforms since on linux platforms, we ship the
+// compiler with assertions enabled. So by disabling this we can at least at
+// the expense of slightly worse debug info when compiling with optimization
+// eliminate these crashes. Darwin does not ship with compiler-asserts so is
+// unaffected.
+#if 0
     // Regular locations are allowed on all instructions.
     if (LocKind == SILLocation::RegularKind)
       return;
@@ -1228,6 +1238,7 @@ class SILVerifier : public SILVerifierBase<SILVerifier> {
     if (LocKind == SILLocation::ArtificialUnreachableKind)
       require(InstKind == SILInstructionKind::UnreachableInst,
         "artificial locations are only allowed on Unreachable instructions");
+#endif
   }
 
   /// Check that the types of this value producer are all legal in the function