Sema: Fix crash on invalid code in isOverrideBasedOnType()

slavapestov · slavapestov · commit 1801bbd37a11 · 2025-06-16T19:46:57.000-04:00
diff --git a/lib/Sema/TypeCheckDeclOverride.cpp b/lib/Sema/TypeCheckDeclOverride.cpp
@@ -217,6 +217,9 @@ bool swift::isOverrideBasedOnType(const ValueDecl *decl, Type declTy,
         return false;
     }
 
+    if (declTy->is<ErrorType>())
+      return false;
+
     auto fnType1 = declTy->castTo<AnyFunctionType>();
     auto fnType2 = parentDeclTy->castTo<AnyFunctionType>();
     return AnyFunctionType::equalParams(fnType1->getParams(),

Original file line number	Diff line number	Diff line change
`@@ -217,6 +217,9 @@ bool swift::isOverrideBasedOnType(const ValueDecl *decl, Type declTy,`
`217`	`217`	`return false;`
`218`	`218`	`}`
`219`	`219`
	`220`	`+ if (declTy->is<ErrorType>())`
	`221`	`+ return false;`
	`222`	`+`
`220`	`223`	`auto fnType1 = declTy->castTo<AnyFunctionType>();`
`221`	`224`	`auto fnType2 = parentDeclTy->castTo<AnyFunctionType>();`
`222`	`225`	`return AnyFunctionType::equalParams(fnType1->getParams(),`