Skip to content

Commit 1950aa4

Browse files
authored
Merge pull request #80252 from etcwilde/ewilde/reenable-ninja-time-tracking
[build-sciprt] Re-enable time tracking local ninja build
2 parents 02fc68b + 321c820 commit 1950aa4

File tree

2 files changed

+17
-10
lines changed

2 files changed

+17
-10
lines changed

utils/swift_build_support/swift_build_support/products/ninja.py

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121

2222
from . import product
2323
from .. import shell
24+
from ..utils import log_time_in_scope
2425

2526

2627
class Ninja(product.Product):
@@ -53,15 +54,18 @@ def ninja_bin_path(self):
5354
def build(self):
5455
if os.path.exists(self.ninja_bin_path):
5556
return
56-
shell.call([
57-
self.toolchain.cmake,
58-
"-S", self.source_dir,
59-
"-B", self.build_dir,
60-
"-DCMAKE_BUILD_TYPE=Release",
61-
"-DBUILD_TESTING=OFF",
62-
f"-DCMAKE_C_COMPILER={self.toolchain.cc}",
63-
f"-DCMAKE_CXX_COMPILER={self.toolchain.cxx}"])
64-
shell.call([self.toolchain.cmake, "--build", self.build_dir])
57+
58+
print("--- Local Ninja Build ---")
59+
with log_time_in_scope('local ninja'):
60+
shell.call([
61+
self.toolchain.cmake,
62+
"-S", self.source_dir,
63+
"-B", self.build_dir,
64+
"-DCMAKE_BUILD_TYPE=Release",
65+
"-DBUILD_TESTING=OFF",
66+
f"-DCMAKE_C_COMPILER={self.toolchain.cc}",
67+
f"-DCMAKE_CXX_COMPILER={self.toolchain.cxx}"])
68+
shell.call([self.toolchain.cmake, "--build", self.build_dir])
6569

6670

6771
def get_ninja_version(ninja_bin_path):

utils/swift_build_support/swift_build_support/utils.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,11 @@ def clear_log_time():
4848

4949

5050
def log_time(event, command, duration=0):
51-
f = open(log_time_path(), "a")
51+
log_time_dir = os.path.dirname(log_time_path())
52+
if not os.path.isdir(log_time_dir):
53+
os.mkdir(log_time_dir)
5254

55+
f = open(log_time_path(), "a")
5356
log_event = {
5457
"event": event,
5558
"command": command,

0 commit comments

Comments
 (0)