Frontend: Warn if adoption mode is requested but not supported

Author: AnthonyLatsis

include/swift/AST/DiagnosticsFrontend.def

@@ -59,6 +59,11 @@ GROUPED_WARNING(cannot_disable_feature_with_mode, StrictLanguageFeatures, none,
                 "'%0' argument '%1' cannot specify a mode",
                 (StringRef, StringRef))
 
+GROUPED_WARNING(feature_does_not_support_adoption_mode, StrictLanguageFeatures,
+                none,
+                "feature '%0' does not support adoption mode",
+                (StringRef))
+
 ERROR(error_unknown_library_level, none,
       "unknown library level '%0', "
       "expected one of 'api', 'spi', 'ipi', or 'other'", (StringRef))

lib/Frontend/CompilerInvocation.cpp

@@ -831,6 +831,13 @@ static bool ParseEnabledFeatureArgs(LangOptions &Opts, ArgList &Args,
                          /*didYouMean=*/validModeName);
           continue;
         }
+
+        if (!isFeatureAdoptable(*feature)) {
+          Diags.diagnose(SourceLoc(),
+                         diag::feature_does_not_support_adoption_mode,
+                         featureName);
+          continue;
+        }
       } else {
         // `-disable-*-feature` flags do not support a mode specifier.
         Diags.diagnose(SourceLoc(), diag::cannot_disable_feature_with_mode,

test/Frontend/strict_features_adoption_mode.swift

@@ -4,8 +4,12 @@
 // RUN: %target-swift-frontend -parse -swift-version 5                         \
 // RUN:   -enable-upcoming-feature      DynamicActorIsolation:invalid1         \
 // RUN:   -enable-upcoming-feature      DynamicActorIsolation:invalid2         \
+// RUN:   -enable-upcoming-feature      DynamicActorIsolation:adoption         \
+// RUN:   -enable-upcoming-feature      DynamicActorIsolation:adoption         \
 // RUN:   -enable-experimental-feature  DynamicActorIsolation:invalid3         \
 // RUN:   -enable-experimental-feature  DynamicActorIsolation:invalid4         \
+// RUN:   -enable-experimental-feature  DynamicActorIsolation:adoption         \
+// RUN:   -enable-experimental-feature  DynamicActorIsolation:adoption         \
 // RUN:   -disable-upcoming-feature     DynamicActorIsolation:invalid5         \
 // RUN:   -disable-upcoming-feature     DynamicActorIsolation:invalid6         \
 // RUN:   -disable-upcoming-feature     DynamicActorIsolation:adoption         \
@@ -36,8 +40,12 @@
 // CHECK-SWIFT-5-NEXT: warning: '-disable-upcoming-feature' argument 'DynamicActorIsolation:adoption' cannot specify a mode{{$}}
 // CHECK-SWIFT-5-NEXT: warning: '-disable-upcoming-feature' argument 'DynamicActorIsolation:invalid6' cannot specify a mode{{$}}
 // CHECK-SWIFT-5-NEXT: warning: '-disable-upcoming-feature' argument 'DynamicActorIsolation:invalid5' cannot specify a mode{{$}}
+// CHECK-SWIFT-5-NEXT: warning: feature 'DynamicActorIsolation' does not support adoption mode{{$}}
+// CHECK-SWIFT-5-NEXT: warning: feature 'DynamicActorIsolation' does not support adoption mode{{$}}
 // CHECK-SWIFT-5-NEXT: warning: 'invalid4' is not a recognized mode for feature 'DynamicActorIsolation'; did you mean 'adoption'?{{$}}
 // CHECK-SWIFT-5-NEXT: warning: 'invalid3' is not a recognized mode for feature 'DynamicActorIsolation'; did you mean 'adoption'?{{$}}
+// CHECK-SWIFT-5-NEXT: warning: feature 'DynamicActorIsolation' does not support adoption mode{{$}}
+// CHECK-SWIFT-5-NEXT: warning: feature 'DynamicActorIsolation' does not support adoption mode{{$}}
 // CHECK-SWIFT-5-NEXT: warning: 'invalid2' is not a recognized mode for feature 'DynamicActorIsolation'; did you mean 'adoption'?{{$}}
 // CHECK-SWIFT-5-NEXT: warning: 'invalid1' is not a recognized mode for feature 'DynamicActorIsolation'; did you mean 'adoption'?{{$}}
 // CHECK-SWIFT-5-NOT: warning: