Revert "[gardening] "Type->Type" → "Type -> Type" in Swift code"

This reverts commit 14edeaf because
it's breaking tests:
https://ci.swift.org/job/oss-swift-incremental-RA-osx/lastFailedBuild/consoleFull#1361088108ee1a197b-acac-4b17-83cf-a53b95139a76

Author: Dave Abrahams

benchmark/single-source/CaptureProp.swift

@@ -17,7 +17,7 @@ func sum(_ x:Int, y:Int) -> Int {
 @inline(never)
 func benchCaptureProp<S : Sequence
 >(
-  _ s: S, _ f: (S.Iterator.Element, S.Iterator.Element) -> S.Iterator.Element) -> S.Iterator.Element {
+  _ s: S, _ f:(S.Iterator.Element, S.Iterator.Element)->S.Iterator.Element) -> S.Iterator.Element {
 
   var it = s.makeIterator()
   let initial = it.next()!

benchmark/single-source/Integrate.swift

@@ -18,13 +18,13 @@ import TestsUtils
 class Integrate {
   static let epsilon = 1.0e-9;
 
-  let fun: (Double) -> Double;
+  let fun:(Double)->Double;
 
-  init (f: (Double) -> Double) {
+  init (f:(Double)->Double) {
     fun = f;
   }
 
-  private func recEval(_ l: Double, fl: Double, r: Double, fr: Double, a: Double) -> Double {
+  private func recEval(_ l:Double, fl:Double, r:Double, fr:Double, a:Double)->Double {
     let h = (r - l) / 2
     let hh = h / 2
     let c = l + h
@@ -43,7 +43,7 @@ class Integrate {
   }
 
   @inline(never)
-  func computeArea(_ left: Double, right: Double) -> Double {
+  func computeArea(_ left: Double, right:Double)->Double {
     return recEval(left, fl:fun(left), r:right, fr:fun(right), a:0)
   }
 }

benchmark/single-source/Prims.swift

@@ -183,7 +183,7 @@ extension Edge : Hashable {
   }
 }
 
-func Prims(_ graph : Array<GraphNode>, _ fun : (Int, Int) -> Double) -> Array<Int?> {
+func Prims(_ graph : Array<GraphNode>, _ fun : (Int, Int)->Double) -> Array<Int?> {
   var treeEdges = Array<Int?>(repeating:nil, count:graph.count)
 
   let queue = PriorityQueue(Num:graph.count)

benchmark/utils/DriverUtils.swift

@@ -48,18 +48,18 @@ extension BenchResults : CustomStringConvertible {
 struct Test {
   let name: String
   let index: Int
-  let f: (Int) -> ()
+  let f: (Int)->()
   var run: Bool
-  init(name: String, n: Int, f: (Int) -> ()) {
+  init(name: String, n: Int, f: (Int)->()) {
     self.name = name
     self.index = n
     self.f = f
     run = true
   }
 }
 
-public var precommitTests: [String : (Int) -> ()] = [:]
-public var otherTests: [String : (Int) -> ()] = [:]
+public var precommitTests: [String : (Int)->()] = [:]
+public var otherTests: [String : (Int)->()] = [:]
 
 enum TestAction {
   case Run

stdlib/private/StdlibUnittest/StdlibUnittest.swift.gyb

@@ -182,7 +182,7 @@ public func expectNotEqual<T : Equatable>(_ expected: T, _ actual: T, ${TRACE})
 }
 
 // Cannot write a sane set of overloads using generics because of:
-// <rdar://problem/17015923> Array -> NSArray implicit conversion insanity
+// <rdar://problem/17015923> Array->NSArray implicit conversion insanity
 public func expectOptionalEqual<T : Equatable>(
   _ expected: T, _ actual: T?, ${TRACE}
 ) {

stdlib/public/core/Print.swift

@@ -31,7 +31,7 @@ public func print(
 #if os(Windows)
   // FIXME: This fix is for 'crash at hook(output.left)' in cygwin.
   //        Proper fix is needed. see: https://bugs.swift.org/browse/SR-612
-  let _playgroundPrintHook: ((String) -> Void)? = nil
+  let _playgroundPrintHook: ((String)->Void)? = nil
 #endif
   if let hook = _playgroundPrintHook {
     var output = _TeeStream(left: "", right: _Stdout())

test/1_stdlib/NewArray.swift.gyb

@@ -144,7 +144,7 @@ func test<
   checkEqual(x, y, false)
 
   func checkReallocations(
-    _ a: T, _ growthDescription: String, _ growBy1: (_: inout T) -> ()
+    _ a: T, _ growthDescription: String, _ growBy1: (_: inout T)->()
   ) {
     var a = a
     var reallocations = 0

test/1_stdlib/Tuple.swift.gyb

@@ -20,7 +20,7 @@ var TupleTestSuite = TestSuite("Tuple")
 func testEquality<A : Equatable, B : Equatable, C : Equatable>(
   _ lhs: (A, B, C), equal: Bool, to rhs: (A, B, C),
   //===--- TRACE boilerplate ----------------------------------------------===//
-  @autoclosure _ message: () -> String = "",
+  @autoclosure _ message: ()->String = "",
   showFrame: Bool = true,
   stackTrace: SourceLocStack = SourceLocStack(),  
   file: String = #file, line: UInt = #line
@@ -94,7 +94,7 @@ enum Ordering : Equatable {
 func testOrdering<A : Comparable, B : Comparable, C : Comparable>(
   _ lhs: (A, B, C), _ ordering: Ordering, _ rhs: (A, B, C),
   //===--- TRACE boilerplate ----------------------------------------------===//
-  @autoclosure _ message: () -> String = "",
+  @autoclosure _ message: ()->String = "",
   showFrame: Bool = true,
   stackTrace: SourceLocStack = SourceLocStack(),  
   file: String = #file, line: UInt = #line

test/Constraints/diagnostics.swift

@@ -147,7 +147,7 @@ public func myMap<C : Collection, T>(
 }
 
 @available(*, unavailable, message: "call the 'map()' method on the optional value")
-public func myMap<T, U>(_ x: T?, @noescape _ f: (T) -> U) -> U? {
+public func myMap<T, U>(_ x: T?, @noescape _ f: (T)->U) -> U? {
   fatalError("unavailable function can't be called")
 }
 

test/Prototypes/CollectionsMoveIndices.swift

@@ -324,7 +324,7 @@
 // a small number of commonly used algorithms that require that
 // property, and they can be provided as methods on the collection,
 // for example removeAll(in: Range<Index>) and
-// removeAll(_: (Element) -> Bool).
+// removeAll(_: (Element)->Bool).
 //
 // If we were to allow reference-counted indices (basically, the
 // current collections model), then an additional design is possible

test/Prototypes/Integers.swift.gyb

@@ -126,7 +126,7 @@ public func _assertCond(
 /// Prints the message if the body is uncommented; used for
 /// diagnostics.
 @_transparent
-public func _log(@autoclosure _ message: () -> String) {
+public func _log(@autoclosure _ message: ()->String) {
   print(message())
 }
 

test/SILGen/implicitly_unwrapped_optional.swift

@@ -1,6 +1,6 @@
 // RUN: %target-swift-frontend -emit-silgen %s | FileCheck %s
 
-func foo(f f: (() -> ())!) {
+func foo(f f: (()->())!) {
   var f = f
   f?()
 }

test/SILGen/optional.swift

@@ -23,7 +23,7 @@ func testCall(_ f: (() -> ())?) {
 // CHECK-NEXT: enum $Optional<()>, #Optional.none!enumelt
 // CHECK-NEXT: br bb2
 
-func testAddrOnlyCallResult<T>(_ f: (() -> T)?) {
+func testAddrOnlyCallResult<T>(_ f: (()->T)?) {
   var f = f
   var x = f?()
 }

test/SourceKit/CursorInfo/cursor_info.swift

@@ -78,7 +78,7 @@ class C3 {
 }
 
 struct S2<T, U where T == U> {
-  func foo<V, W where V == W> (_ closure: () -> ()) -> () -> () { return closure }
+  func foo<V, W where V == W> (_ closure: ()->()) -> ()->() { return closure }
 }
 class C4<T, U where T == U> {}
 enum E1<T, U where T == U> {}
@@ -127,7 +127,7 @@ func genReq<U, V: P1 where V.T == U>(_ u: U, v: V) {}
 }
 
 let tupleVar1: (((Int, Int), y: Int), z: Int)
-let tupleVar2: (f: () -> (), g: (x: Int) -> Int)
+let tupleVar2: (f: ()->(), g: (x: Int)->Int)
 let tupleVar3: (f: (inout x: (Int, Int)) throws ->(), Int)
 
 enum E4: Int {
@@ -152,9 +152,9 @@ protocol P2: class, P1 {}
 typealias MyAlias<T, U> = (T, U, T, U)
 typealias MyAlias2<A, B> = MyAlias<A, B>
 
-func paramAutoclosureNoescape1(@noescape _ msg: () -> String) {}
-func paramAutoclosureNoescape2(@autoclosure _ msg: () -> String) {}
-func paramAutoclosureNoescape3(@autoclosure(escaping) _ msg: () -> String) {}
+func paramAutoclosureNoescape1(@noescape _ msg: ()->String) {}
+func paramAutoclosureNoescape2(@autoclosure _ msg: ()->String) {}
+func paramAutoclosureNoescape3(@autoclosure(escaping) _ msg: ()->String) {}
 
 func paramDefaultPlaceholder(_ f: StaticString = #function, file: StaticString = #file, line: UInt = #line, col: UInt = #column, arr: [Int] = [], dict: [Int:Int] = [:], opt: Int? = nil, reg: Int = 1) {}
 

test/decl/typealias/typealias.swift

@@ -72,7 +72,7 @@ typealias D<T1, T2, T3> = MyType<T2, T1>  // expected-note {{'T3' declared as pa
 
 typealias E<T1, T2> = Int  // expected-note {{generic type 'E' declared here}}
 
-typealias F<T1, T2> = T1 -> T2
+typealias F<T1, T2> = T1->T2
 
 // Type alias of type alias.
 typealias G<S1, S2> = A<S1, S2>

validation-test/stdlib/OpenCLSDKOverlay.swift

@@ -130,7 +130,7 @@ tests.test("clSetKernelArgsListAPPLE") {
   // Create the compute program from the source buffer
   //
   program = KernelSource.withCString {
-    (p: UnsafePointer<CChar>) -> cl_program in
+    (p: UnsafePointer<CChar>)->cl_program in
     var s: UnsafePointer? = p
     return withUnsafeMutablePointer(&s) {
       return clCreateProgramWithSource(context, 1, $0, nil, &err)