Use emitDestroyValueOperation instead of createStrongRelease

aschwaighofer · aschwaighofer · commit 1c67e1ebb396 · 2017-11-04T15:13:49.000-07:00
diff --git a/lib/SILOptimizer/SILCombiner/SILCombinerApplyVisitors.cpp b/lib/SILOptimizer/SILCombiner/SILCombinerApplyVisitors.cpp
@@ -335,17 +335,15 @@ bool PartialApplyCombiner::processSingleApply(FullApplySite AI) {
       Builder.emitDestroyValueOperation(PAI->getLoc(), Arg);
     }
     if (!PAI->hasCalleeGuaranteedContext())
-      Builder.createStrongRelease(AI.getLoc(), PAI,
-                                  Builder.getDefaultAtomicity());
+      Builder.emitDestroyValueOperation(PAI->getLoc(), PAI);
     Builder.setInsertionPoint(AI.getInstruction());
   } else {
     // Release the non-consumed parameters.
     for (auto Arg : ToBeReleasedArgs) {
       Builder.emitDestroyValueOperation(PAI->getLoc(), Arg);
     }
     if (!PAI->hasCalleeGuaranteedContext())
-      Builder.createStrongRelease(AI.getLoc(), PAI,
-                                  Builder.getDefaultAtomicity());
+      Builder.emitDestroyValueOperation(PAI->getLoc(), PAI);
   }
 
   if (auto apply = dyn_cast<ApplyInst>(AI))

Original file line number	Diff line number	Diff line change
`@@ -335,17 +335,15 @@ bool PartialApplyCombiner::processSingleApply(FullApplySite AI) {`
`335`	`335`	`Builder.emitDestroyValueOperation(PAI->getLoc(), Arg);`
`336`	`336`	`}`
`337`	`337`	`if (!PAI->hasCalleeGuaranteedContext())`
`338`		`- Builder.createStrongRelease(AI.getLoc(), PAI,`
`339`		`- Builder.getDefaultAtomicity());`
	`338`	`+ Builder.emitDestroyValueOperation(PAI->getLoc(), PAI);`
`340`	`339`	`Builder.setInsertionPoint(AI.getInstruction());`
`341`	`340`	`} else {`
`342`	`341`	`// Release the non-consumed parameters.`
`343`	`342`	`for (auto Arg : ToBeReleasedArgs) {`
`344`	`343`	`Builder.emitDestroyValueOperation(PAI->getLoc(), Arg);`
`345`	`344`	`}`
`346`	`345`	`if (!PAI->hasCalleeGuaranteedContext())`
`347`		`- Builder.createStrongRelease(AI.getLoc(), PAI,`
`348`		`- Builder.getDefaultAtomicity());`
	`346`	`+ Builder.emitDestroyValueOperation(PAI->getLoc(), PAI);`
`349`	`347`	`}`
`350`	`348`
`351`	`349`	`if (auto apply = dyn_cast<ApplyInst>(AI))`