Skip to content

Commit 1d551cb

Browse files
authored
Merge pull request #20006 from jmittert/EnhanceWindowsDocs
Clarified Windows build docs
2 parents 287e211 + c4021d8 commit 1d551cb

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

docs/WindowsBuild.md

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,12 @@ set swift_source_dir=path-to-directory-containing-all-cloned-repositories
8989
(`Debug`, `RelWithDebInfoAssert` or `Release`) to avoid conflicts between the debug and
9090
non-debug version of the MSCRT library.
9191

92+
- Set up the `visualc` and `ucrt` modules by copying `ucrt.modulemap` located at
93+
`swift/stdlib/public/Platform/ucrt.modulemap` into
94+
`${UniversalCRTSdkDir}/Include/${UCRTVersion}/ucrt` as `module.modulemap` and copying `visualc.modulemap` located at `swift/stdlib/public/Platform/visualc.modulemap` into `${VCToolsInstallDir}/include` as `module.modulemap`
95+
96+
97+
9298
### 5. Build CMark
9399
- This must be done from within a developer command prompt. CMark is a fairly
94100
small project and should only take a few minutes to build.
@@ -150,9 +156,9 @@ cmake -G "Ninja" "%swift_source_dir%/swift"^
150156
-DSWIFT_PATH_TO_LLVM_BUILD="%swift_source_dir%/build/Ninja-DebugAssert/llvm-windows-amd64"^
151157
-DSWIFT_PATH_TO_CLANG_SOURCE="%swift_source_dir%/llvm/tools/clang"^
152158
-DSWIFT_PATH_TO_CLANG_BUILD="%swift_source_dir%/build/Ninja-DebugAssert/llvm-windows-amd64"^
153-
-DICU_UC_INCLUDE_DIR="%swift_source_dir%/icu/include"^
159+
-DICU_UC_INCLUDE_DIRS="%swift_source_dir%/icu/include"^
154160
-DICU_UC_LIBRARY_DIRS="%swift_source_dir%/icu/lib64"^
155-
-DICU_I18N_INCLUDE_DIR="%swift_source_dir%/icu/include"^
161+
-DICU_I18N_INCLUDE_DIRS="%swift_source_dir%/icu/include"^
156162
-DICU_I18N_LIBRARY_DIRS="%swift_source_dir%/icu/lib64"^
157163
-DICU_UC_LIB_NAME="icuuc"^
158164
-DICU_I18N_LIB_NAME="icuin"^

docs/WindowsCrossCompile.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ export VCToolsInstallDir=".../Microsoft Visual Studio/2017/Community"
1919
## 2. Set up the `visualc` and `ucrt` modules
2020
The `ucrt.modulemap` located at
2121
`swift/stdlib/public/Platform/ucrt.modulemap` needs to be copied into
22-
`${UniversalCRTSdkDir}/Include/${UCRTVersion}/ucrt`. The `visualc.modulemap`
23-
located at `swift/stdlib/public/Platform/visualc.modulemap` needs to be copied
24-
into `${VCToolsInstallDir}/include`.
22+
`${UniversalCRTSdkDir}/Include/${UCRTVersion}/ucrt` as `module.modulemap`. The
23+
`visualc.modulemap` located at `swift/stdlib/public/Platform/visualc.modulemap`
24+
needs to be copied into `${VCToolsInstallDir}/include` as `module.modulemap`
2525

2626
## 3. Configure the runtime to be built with the just built `clang`
2727
Ensure that we use the tools from the just built LLVM and `clang` tools to

0 commit comments

Comments
 (0)