Skip to content

Commit 1ddfa58

Browse files
committed
fixup! [Sema] Add fix-it for property in protocol
1 parent da9a19b commit 1ddfa58

File tree

1 file changed

+5
-11
lines changed

1 file changed

+5
-11
lines changed

lib/Sema/CodeSynthesis.cpp

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2023,21 +2023,15 @@ void swift::maybeAddAccessorsToStorage(TypeChecker &TC,
20232023
} else if (isa<ProtocolDecl>(dc)) {
20242024
if (storage->hasStorage()) {
20252025
auto var = cast<VarDecl>(storage);
2026-
auto braces = var->getBracesRange();
20272026

20282027
if (var->isLet()) {
2029-
auto diag = TC.diagnose(var->getLoc(),
2030-
diag::protocol_property_must_be_computed_var);
2031-
if (braces.isValid())
2032-
diag
2033-
.fixItReplace(var->getParentPatternBinding()->getLoc(), "var")
2034-
.fixItReplace(braces, " { get }");
2035-
else
2036-
diag
2037-
.fixItReplace(var->getParentPatternBinding()->getLoc(), "var")
2038-
.fixItInsertAfter(var->getTypeLoc().getLoc(), " { get }");
2028+
TC.diagnose(var->getLoc(),
2029+
diag::protocol_property_must_be_computed_var)
2030+
.fixItReplace(var->getParentPatternBinding()->getLoc(), "var")
2031+
.fixItInsertAfter(var->getTypeLoc().getLoc(), " { get }");
20392032
} else {
20402033
auto diag = TC.diagnose(var->getLoc(), diag::protocol_property_must_be_computed);
2034+
auto braces = var->getBracesRange();
20412035

20422036
if (braces.isValid())
20432037
diag.fixItReplace(braces, "{ get <#set#> }");

0 commit comments

Comments
 (0)