SIL: Strip [serialized] flag from functions even at -Onone

While the comment is correct to state that this won't enable any
new optimizations with -Onone, it does enable IRGen's lazy
function emission, which is important for 'reasync' functions,
which we don't want to emit at all even at -Onone.

This fixes debug stdlib builds with the new reasync versions
of the &&, || and ?? operators.

Author: slavapestov

lib/SILOptimizer/UtilityPasses/SerializeSILPass.cpp

@@ -451,21 +451,9 @@ class SerializeSILPass : public SILModuleTransform {
         !M.getOptions().CrossModuleOptimization)
       return;
 
-    // Mark all reachable functions as "anchors" so that they are not
-    // removed later by the dead function elimination pass. This
-    // is required, because clients may reference any of the
-    // serialized functions or anything referenced from them. Therefore,
-    // to avoid linker errors, the object file of the current module should
-    // contain all the symbols which were alive at the time of serialization.
     LLVM_DEBUG(llvm::dbgs() << "Serializing SILModule in SerializeSILPass\n");
     M.serialize();
 
-    // If we are not optimizing, do not strip the [serialized] flag. We *could*
-    // do this since after serializing [serialized] is irrelevent. But this
-    // would incur an unnecessary compile time cost since if we are not
-    // optimizing we are not going to perform any sort of DFE.
-    if (!getOptions().shouldOptimize())
-      return;
     removeSerializedFlagFromAllFunctions(M);
   }
 };

test/AutoDiff/SILOptimizer/differentiation_subset_parameters_thunk.swift

@@ -81,7 +81,7 @@ func genericInoutIndirectCaller<T: Differentiable, U: Differentiable>(
   return inoutIndirectCaller(x, y, z)
 }
 
-// CHECK-LABEL: sil shared [transparent] [serialized] [thunk] @$sSdSfSdSfIegnrrr_TJSpSSSpSrSUSP : $@convention(thin) (@in_guaranteed Double, @guaranteed @callee_guaranteed (@in_guaranteed Double) -> (@out Float, @out Double, @out Float)) -> (@out Float, @out Float) {
+// CHECK-LABEL: sil shared [transparent] [thunk] @$sSdSfSdSfIegnrrr_TJSpSSSpSrSUSP : $@convention(thin) (@in_guaranteed Double, @guaranteed @callee_guaranteed (@in_guaranteed Double) -> (@out Float, @out Double, @out Float)) -> (@out Float, @out Float) {
 // CHECK: bb0(%0 : $*Float, %1 : $*Float, %2 : $*Double, %3 : $@callee_guaranteed (@in_guaranteed Double) -> (@out Float, @out Double, @out Float)):
 // CHECK:   %4 = alloc_stack $Double
 // CHECK:   %5 = apply %3(%0, %4, %1, %2) : $@callee_guaranteed (@in_guaranteed Double) -> (@out Float, @out Double, @out Float)
@@ -91,7 +91,7 @@ func genericInoutIndirectCaller<T: Differentiable, U: Differentiable>(
 // CHECK:   return %8 : $()
 // CHECK: }
 
-// CHECK-LABEL: sil shared [transparent] [serialized] [thunk] @$s13TangentVector16_Differentiation14DifferentiablePQy_AaDQzAaDQy0_Ieglrr_TJSpSSSpSrSSUP : $@convention(thin) <τ_0_0, τ_0_1, τ_0_2 where τ_0_0 : Differentiable, τ_0_1 : Differentiable, τ_0_2 : Differentiable> (@inout τ_0_1.TangentVector, @guaranteed @callee_guaranteed (@inout τ_0_1.TangentVector) -> (@out τ_0_0.TangentVector, @out τ_0_2.TangentVector)) -> @out τ_0_0.TangentVector {
+// CHECK-LABEL: sil shared [transparent] [thunk] @$s13TangentVector16_Differentiation14DifferentiablePQy_AaDQzAaDQy0_Ieglrr_TJSpSSSpSrSSUP : $@convention(thin) <τ_0_0, τ_0_1, τ_0_2 where τ_0_0 : Differentiable, τ_0_1 : Differentiable, τ_0_2 : Differentiable> (@inout τ_0_1.TangentVector, @guaranteed @callee_guaranteed (@inout τ_0_1.TangentVector) -> (@out τ_0_0.TangentVector, @out τ_0_2.TangentVector)) -> @out τ_0_0.TangentVector {
 // CHECK: bb0(%0 : $*τ_0_0.TangentVector, %1 : $*τ_0_1.TangentVector, %2 : $@callee_guaranteed (@inout τ_0_1.TangentVector) -> (@out τ_0_0.TangentVector, @out τ_0_2.TangentVector)):
 // CHECK:   %3 = alloc_stack $τ_0_2.TangentVector
 // CHECK:   %4 = apply %2(%0, %3, %1) : $@callee_guaranteed (@inout τ_0_1.TangentVector) -> (@out τ_0_0.TangentVector, @out τ_0_2.TangentVector)
@@ -101,7 +101,7 @@ func genericInoutIndirectCaller<T: Differentiable, U: Differentiable>(
 // CHECK:   return %7 : $()
 // CHECK: }
 
-// CHECK-LABEL: sil shared [transparent] [serialized] [thunk] @$s13TangentVector16_Differentiation14DifferentiablePQy_AaDQzAaDQy0_Ieglrr_TJSpSSSpSrUSUP : $@convention(thin) <τ_0_0, τ_0_1, τ_0_2 where τ_0_0 : Differentiable, τ_0_1 : Differentiable, τ_0_2 : Differentiable> (@inout τ_0_1.TangentVector, @guaranteed @callee_guaranteed (@inout τ_0_1.TangentVector) -> (@out τ_0_0.TangentVector, @out τ_0_2.TangentVector)) -> () {
+// CHECK-LABEL: sil shared [transparent] [thunk] @$s13TangentVector16_Differentiation14DifferentiablePQy_AaDQzAaDQy0_Ieglrr_TJSpSSSpSrUSUP : $@convention(thin) <τ_0_0, τ_0_1, τ_0_2 where τ_0_0 : Differentiable, τ_0_1 : Differentiable, τ_0_2 : Differentiable> (@inout τ_0_1.TangentVector, @guaranteed @callee_guaranteed (@inout τ_0_1.TangentVector) -> (@out τ_0_0.TangentVector, @out τ_0_2.TangentVector)) -> () {
 // CHECK: bb0(%0 : $*τ_0_1.TangentVector, %1 : $@callee_guaranteed (@inout τ_0_1.TangentVector) -> (@out τ_0_0.TangentVector, @out τ_0_2.TangentVector)):
 // CHECK:   %2 = alloc_stack $τ_0_0.TangentVector
 // CHECK:   %3 = alloc_stack $τ_0_2.TangentVector

test/ClangImporter/const_and_pure.swift

@@ -8,8 +8,8 @@ func testit() {
 	normal_function()
 }
 
-// CHECK: sil [serializable] [readnone] [clang const_function] @const_function : $@convention(c) () -> ()
-// CHECK: sil [serializable] [readonly] [clang pure_function] @pure_function : $@convention(c) () -> ()
-// CHECK: sil [serializable] [clang normal_function] @normal_function : $@convention(c) () -> ()
+// CHECK: sil [readnone] [clang const_function] @const_function : $@convention(c) () -> ()
+// CHECK: sil [readonly] [clang pure_function] @pure_function : $@convention(c) () -> ()
+// CHECK: sil [clang normal_function] @normal_function : $@convention(c) () -> ()
 
 

test/ClangImporter/enum-error.swift

@@ -45,30 +45,30 @@ func testError() {
   } catch {}
 
 #elseif ASQEXPR
-// ASQEXPR: sil_witness_table shared [serialized] TestError: _BridgedStoredNSError module __ObjC
+// ASQEXPR: sil_witness_table shared TestError: _BridgedStoredNSError module __ObjC
   let wasTestError = testErrorNSError as? TestError; wasTestError
 
 #elseif ASBANGEXPR
-// ASBANGEXPR: sil_witness_table shared [serialized] TestError: _BridgedStoredNSError module __ObjC
+// ASBANGEXPR: sil_witness_table shared TestError: _BridgedStoredNSError module __ObjC
   let terr2 = testErrorNSError as! TestError; terr2
 
 #elseif ISEXPR
-// ISEXPR: sil_witness_table shared [serialized] TestError: _BridgedStoredNSError module __ObjC
+// ISEXPR: sil_witness_table shared TestError: _BridgedStoredNSError module __ObjC
   if (testErrorNSError is TestError) {
     print("true")
   } else {
     print("false")
   }
 
 #elseif CATCHIS
-// CATCHIS: sil_witness_table shared [serialized] TestError: _BridgedStoredNSError module __ObjC
+// CATCHIS: sil_witness_table shared TestError: _BridgedStoredNSError module __ObjC
   do {
     throw TestError(.TETwo)
   } catch is TestError {
   } catch {}
 
 #elseif CATCHAS
-// CATCHAS: sil_witness_table shared [serialized] TestError: _BridgedStoredNSError module __ObjC
+// CATCHAS: sil_witness_table shared TestError: _BridgedStoredNSError module __ObjC
   do {
     throw TestError(.TETwo)
   } catch let err as TestError {
@@ -83,8 +83,8 @@ func testError() {
   let _ : TestError = dyncast(testErrorNSError)
 
 #elseif EXHAUSTIVE
-// CHECK: sil_witness_table shared [serialized] TestError: _BridgedStoredNSError module __ObjC
-// CHECK: sil_witness_table shared [serialized] ExhaustiveError: _BridgedStoredNSError module __ObjC
+// CHECK: sil_witness_table shared TestError: _BridgedStoredNSError module __ObjC
+// CHECK: sil_witness_table shared ExhaustiveError: _BridgedStoredNSError module __ObjC
   let terr = getErr()
   switch (terr) { case .TENone, .TEOne, .TETwo: break }
   // EXHAUSTIVE: [[@LINE-1]]:{{.+}}: warning: switch covers known cases, but 'TestError.Code' may have additional unknown values

test/ClangImporter/static_inline.swift

@@ -6,7 +6,7 @@
 // RUN: %FileCheck < %t/static_inline.sil %s
 // RUN: %target-swift-frontend -parse-as-library -module-name=static_inline -O -emit-ir %t/static_inline.sil -enable-objc-interop -import-objc-header %S/Inputs/static_inline.h | %FileCheck --check-prefix=CHECK-IR %s
 
-// CHECK: sil shared [serializable] [clang c_inline_func] @c_inline_func : $@convention(c) (Int32) -> Int32
+// CHECK: sil shared [clang c_inline_func] @c_inline_func : $@convention(c) (Int32) -> Int32
 
 // CHECK-IR-LABEL: define{{.*}} i32 @"$s13static_inline6testit1xs5Int32VAE_tF"(i32 %0)
 // CHECK-IR: = add {{.*}}, 27

test/IRGen/alwaysEmitIntoClient.swift

@@ -0,0 +1,32 @@
+// RUN: %target-swift-frontend -emit-ir %s -O | %FileCheck %s --check-prefix=OPTIMIZED
+// RUN: %target-swift-frontend -emit-ir %s | %FileCheck %s
+// RUN: %target-swift-frontend -emit-ir %s | %FileCheck %s --check-prefix=NEGATIVE
+// RUN: %target-swift-frontend -emit-ir -primary-file %s | %FileCheck %s --check-prefix=PRIMARY
+
+// Make sure that @_alwaysEmitIntoClient functions are lazily
+// emitted in WMO builds.
+
+// Both functions are eliminated in optimized builds; the first is inlined
+// into the caller, and the second is eliminated since it was never called.
+
+// OPTIMIZED-NOT: define weak_odr hidden swiftcc void @"$s20alwaysEmitIntoClient18referencedFunctionyyF"() {{.*}} {
+// OPTIMIZED-NOT: define weak_odr hidden swiftcc void @"$s20alwaysEmitIntoClient20unreferencedFunctionyyF"() {{.*}} {
+
+// The unreferenced function should be eliminated in an unoptimized WMO
+// build too, since it was never referenced from inside the module.
+
+// CHECK-LABEL: define linkonce_odr hidden swiftcc void @"$s20alwaysEmitIntoClient18referencedFunctionyyF"() {{.*}} {
+// NEGATIVE-NOT: define linkonce_odr hidden swiftcc void @"$s20alwaysEmitIntoClient20unreferencedFunctionyyF"() {{.*}} {
+
+// In non-WMO mode, both functions must be emitted since they could be
+// referenced from other translation units.
+
+// PRIMARY-LABEL: define weak_odr hidden swiftcc void @"$s20alwaysEmitIntoClient18referencedFunctionyyF"() {{.*}} {
+// PRIMARY-LABEL: define weak_odr hidden swiftcc void @"$s20alwaysEmitIntoClient20unreferencedFunctionyyF"() {{.*}} {
+
+@_alwaysEmitIntoClient public func referencedFunction() {}
+@_alwaysEmitIntoClient public func unreferencedFunction() {}
+
+public func referencesFunction() {
+  referencedFunction()
+}

test/IRGen/opaque_result_type_debug.swift

@@ -1,36 +1,30 @@
-// RUN: %target-swift-frontend -enable-library-evolution -disable-availability-checking -g -emit-ir -enable-anonymous-context-mangled-names %s | %FileCheck %s
+// RUN: %empty-directory(%t)
+// RUN: %target-swift-frontend -enable-library-evolution -disable-availability-checking -emit-module -emit-module-path %t/opaque_result_type_debug_other.swiftmodule -module-name opaque_result_type_debug_other -enable-anonymous-context-mangled-names %s -DLIBRARY
+// RUN: %target-swift-frontend -disable-availability-checking -g -emit-ir -enable-anonymous-context-mangled-names %s -DCLIENT -I %t | %FileCheck %s
+
+#if LIBRARY
 
 public protocol P {}
 extension Int: P {} 
 
-// CHECK: [[DEFINER_NAME:@.*]] = {{.*}}constant [{{[0-9]+}} x i8] c"$s24opaque_result_type_debug3fooQryF\00"
-// CHECK: @"$s24opaque_result_type_debug3fooQryFMXX" = {{.*}}constant{{.*}} [[DEFINER_NAME]]
-// CHECK: @"$s24opaque_result_type_debug3fooQryFQOMQ" = {{.*}}constant{{.*}} @"$s24opaque_result_type_debug3fooQryFMXX"
-
 public func foo() -> some P {
   return 0
 }
 
-// CHECK: [[DEFINER_NAME:@.*]] = {{.*}}constant [{{[0-9]+}} x i8] c"$s24opaque_result_type_debug4propQrvp\00"
-// CHECK: @"$s24opaque_result_type_debug4propQrvpMXX" = {{.*}}constant{{.*}} [[DEFINER_NAME]]
-// CHECK: @"$s24opaque_result_type_debug4propQrvpQOMQ" = {{.*}}constant{{.*}} @"$s24opaque_result_type_debug4propQrvpMXX"
-
 public var prop: some P {
   return 0
 }
 
-// CHECK: [[DEFINER_NAME:@.*]] = {{.*}}constant [{{[0-9]+}} x i8] c"$s24opaque_result_type_debug3FooVQrycip\00"
-// CHECK: @"$s24opaque_result_type_debug3FooVQrycipMXX" = {{.*}}constant{{.*}} [[DEFINER_NAME]]
-// CHECK: @"$s24opaque_result_type_debug3FooVQrycipQOMQ" = {{.*}}constant{{.*}} @"$s24opaque_result_type_debug3FooVQrycipMXX"
-
 public struct Foo {
   public init() {}
   public subscript() -> some P {
     return 0
   }
 }
 
-// CHECK: @"\01l_type_metadata_table" = {{.*}} @"$s24opaque_result_type_debug3fooQryFQOMQ"
+#else
+
+import opaque_result_type_debug_other
 
 @_silgen_name("use") public func use<T: P>(_: T)
 
@@ -51,11 +45,13 @@ public func bar<T: P>(genericValue: T) {
   use(opaqueSubValue)
 }
 
-// CHECK-DAG: ![[OPAQUE_TYPE:[0-9]+]] = !DICompositeType({{.*}} name: "$s24opaque_result_type_debug3fooQryFQOyQo_D"
+#endif
+
+// CHECK-DAG: ![[OPAQUE_TYPE:[0-9]+]] = !DICompositeType({{.*}} name: "$s30opaque_result_type_debug_other3fooQryFQOyQo_D"
 // CHECK-DAG: ![[LET_OPAQUE_TYPE:[0-9]+]] = !DIDerivedType(tag: DW_TAG_const_type, baseType: ![[OPAQUE_TYPE]])
-// CHECK-DAG: ![[OPAQUE_PROP_TYPE:[0-9]+]] = !DICompositeType({{.*}} name: "$s24opaque_result_type_debug4propQrvpQOyQo_D"
+// CHECK-DAG: ![[OPAQUE_PROP_TYPE:[0-9]+]] = !DICompositeType({{.*}} name: "$s30opaque_result_type_debug_other4propQrvpQOyQo_D"
 // CHECK-DAG: ![[LET_OPAQUE_PROP_TYPE:[0-9]+]] = !DIDerivedType(tag: DW_TAG_const_type, baseType: ![[OPAQUE_PROP_TYPE]])
-// CHECK-DAG: ![[OPAQUE_SUB_TYPE:[0-9]+]] = !DICompositeType({{.*}} name: "$s24opaque_result_type_debug3FooVQrycipQOy_Qo_D"
+// CHECK-DAG: ![[OPAQUE_SUB_TYPE:[0-9]+]] = !DICompositeType({{.*}} name: "$s30opaque_result_type_debug_other3FooVQrycipQOy_Qo_D"
 // CHECK-DAG: ![[LET_OPAQUE_SUB_TYPE:[0-9]+]] = !DIDerivedType(tag: DW_TAG_const_type, baseType: ![[OPAQUE_SUB_TYPE]])
 // CHECK-DAG: {{![0-9]+}} = !DILocalVariable(name: "opaqueValue",{{.*}} type: ![[LET_OPAQUE_TYPE]])
 // CHECK-DAG: {{![0-9]+}} = !DILocalVariable(name: "opaquePropValue",{{.*}} type: ![[LET_OPAQUE_PROP_TYPE]])

test/IRGen/opaque_result_type_substitution.swift

@@ -25,141 +25,9 @@ public func usePair<T, V>(_ t: T, _ v: V) {
   print(p)
 }
 
-protocol P { }
-
-struct C<S : Hashable> {
-    struct Inner {}
-
-    init(_ s: S) { }
-
-    func getInner() -> Inner {
-      return Inner()
-    }
-}
-
-struct O<T> {
-  var t: T
-
-  init(_ t: T) {
-    self.t = t
-  }
-}
-
-struct M<T, V> : P {
-  init(_ f: T, _ s: V) {
-  }
-
-  func foobar() -> some P {
-    return self
-  }
-}
-
-public func test2<S : Hashable, T, V>(_ s: S, _ t: T, _ v: V) {
-  var x = M(C(s).getInner(), t)
-  let q = x.foobar()
-  let u = x.foobar()
-  let y = O(q)
-  print(y)
-}
-
 // CHECK-LABEL: define{{.*}} swiftcc void @"$s31opaque_result_type_substitution7usePairyyx_q_tr0_lF"({{.*}}, %swift.type* %T, %swift.type* %V)
 // CHECK:  [[PAIR_TV:%.*]] = call swiftcc %swift.metadata_response @"$s31opaque_result_type_substitution4PairVMa"({{.*}}, %swift.type* %T, %swift.type* %V)
 // CHECK:  [[MD:%.*]] = extractvalue %swift.metadata_response [[PAIR_TV]], 0
 // CHECK:  [[PAIR_OPAQUE:%.*]] = call swiftcc %swift.metadata_response @"$s31opaque_result_type_substitution4PairVMa"({{.*}}, %swift.type* [[MD]], %swift.type* [[MD]])
 // CHECK:  [[MD2:%.*]] = extractvalue %swift.metadata_response [[PAIR_OPAQUE]], 0
-// CHECK:  call {{.*}}* @"$s31opaque_result_type_substitution4PairVyAC6foobarQryFQOyxq__Qo_AEGr0_lWOh"({{.*}}, %swift.type* {{.*}}, %swift.type* [[MD2]])
-
-public protocol Thing { }
-
-public struct Thingy : Thing {}
-
-public protocol KeyProto {
-  associatedtype Value
-}
-
-extension KeyProto {
-  public static func transform3<T : Thing>(
-    _ transform: @escaping (A<Self>) -> T)
-  -> some Thing {
-      return Thingy()
-  }
-}
-
-public struct A<Key : KeyProto> {}
-
-extension A {
-  public func transform2<T>(_ transform: @escaping (Key.Value) -> T) -> Thingy {
-    return Thingy()
-  }
-}
-
-struct AKey : KeyProto {
-  typealias Value = Int
-}
-
-extension Thing {
-  public func transform<K>(key _: K.Type = K.self, transform: @escaping (inout K) -> Void) -> some Thing {
-    return Thingy()
-  }
-}
-
-struct OutterThing<Content : Thing> : Thing {
-  let content: Content
-
-  init(_ c: Content) {
-    self.content = c
-  }
-
-  var body: some Thing {
-    return AKey.transform3 { y in
-      y.transform2 { i in
-       self.content.transform(
-         key: Thingy.self) { value in }
-      }
-    }
-  }
-}
-
-public protocol W {}
-
-struct Key : W {}
-
-extension W {
-  public static func transform(_ transform: @escaping (P1<Self>) -> ()) -> some W {
-    return Key()
-  }
-}
-
-public struct P1<Key : W> { }
-
-extension P1 {
-  public func transform2<T>(_ transform: @escaping (Key) -> T) { }
-}
-
-public struct T<Content> : W {
-  public init(content : ()->Content) {}
-}
-
-public struct Content<Content> : W {
-  public init(content: Content) {}
-}
-
-extension W {
-  func moo() -> some W {
-    return Content(content: self)
-  }
-}
-
-struct Test<Label : W> {
-  var label: Label
-  // This function used to crash.
-  var dontCrash: some W {
-    return Key.transform { y in
-      y.transform2 { i in
-        T() {
-          return self.label
-        }.moo()
-      }
-    }
-  }
-}
+// CHECK:  call {{.*}}* @"$s31opaque_result_type_substitution4PairVyACyxq_GADGr0_lWOh"({{.*}}, %swift.type* {{.*}}, %swift.type* [[MD2]])